Use the Google report-uri for badssl Expect-CT site

Use the Google report-uri for badssl Expect-CT site

This change goes along with
https://github.com/chromium/badssl.com/pull/206, which adds the
preloaded-expect-ct.badssl.com to badssl.com and serves the Expect-CT
header with no SCTs. Along with this CL, we'll get an easy way to
manually test Expect-CT end-to-end, by visiting
preloaded-expect-ct.badssl.com in Chrome and seeing that a report gets
generated and logged on the server side.

BUG=

Committed: https://crrev.com/960fde37768267fb16f8b7ffd7bc4d4bac10bb4c
Cr-Commit-Position: refs/heads/master@{#418425}

[estark, 2016-09-13 21:51:39]

estark@chromium.org changed reviewers:
+ lgarron@chromium.org

[estark, 2016-09-13 21:51:39]

lgarron, PTAL alongside https://github.com/chromium/badssl.com/pull/206

[estark, 2016-09-13 21:52:50]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-09-13 21:57:44]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:26:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[estark, 2016-09-13 22:32:20]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 22:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-09-13 22:56:13]

lgtm

[estark, 2016-09-13 23:01:23]

estark@chromium.org changed reviewers:
+ eroman@chromium.org

[estark, 2016-09-13 23:01:23]

eroman, can you please review the change to
net/http/transport_security_state_unittest.cc?

[eroman, 2016-09-13 23:19:44]

lgtm after understanding the kPreloadedHSTSData changes.

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
File net/http/transport_security_state_static.h (right):

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
net/http/transport_security_state_static.h:3642: 0x13, 0xc9, 0x62, 0xd2, 0x5a,
0x0a, 0xf9, 0xb3, 0x21, 0xdb, 0xfc, 0x52,
Is kPreloadedHSTSData generated from transport_security_state_static.json ?

I didn't see any comments in the code describing where this comes from.

Not sure how to verify and review these changes otherwise, since looks like a
blob of binary.

[estark, 2016-09-13 23:23:18]

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
File net/http/transport_security_state_static.h (right):

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
net/http/transport_security_state_static.h:3642: 0x13, 0xc9, 0x62, 0xd2, 0x5a,
0x0a, 0xf9, 0xb3, 0x21, 0xdb, 0xfc, 0x52,
On 2016/09/13 23:19:44, eroman wrote:
> Is kPreloadedHSTSData generated from transport_security_state_static.json ?
> 
> I didn't see any comments in the code describing where this comes from.
> 
> Not sure how to verify and review these changes otherwise, since looks like a
> blob of binary.

Yep, this is generated from the JSON file. See the comment on line 5 of this
file.

[eroman, 2016-09-13 23:30:47]

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
File net/http/transport_security_state_static.h (right):

https://codereview.chromium.org/2336373002/diff/40001/net/http/transport_secu...
net/http/transport_security_state_static.h:3642: 0x13, 0xc9, 0x62, 0xd2, 0x5a,
0x0a, 0xf9, 0xb3, 0x21, 0xdb, 0xfc, 0x52,
On 2016/09/13 23:23:18, estark wrote:
> On 2016/09/13 23:19:44, eroman wrote:
> > Is kPreloadedHSTSData generated from transport_security_state_static.json ?
> > 
> > I didn't see any comments in the code describing where this comes from.
> > 
> > Not sure how to verify and review these changes otherwise, since looks like
a
> > blob of binary.
> 
> Yep, this is generated from the JSON file. See the comment on line 5 of this
> file.

Thanks! I seem to be incapable of ever noticing file-level comments, they just
blur into the Copyright for me...

[commit-bot: I haz the power, 2016-09-13 23:52:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:52:52]

Dry run: This issue passed the CQ dry run.

[estark, 2016-09-13 23:54:03]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:07:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 00:09:12]

Description was changed from

==========
Use the Google report-uri for badssl Expect-CT site

This change goes along with
https://github.com/chromium/badssl.com/pull/206, which adds the
preloaded-expect-ct.badssl.com to badssl.com and serves the Expect-CT
header with no SCTs. Along with this CL, we'll get an easy way to
manually test Expect-CT end-to-end, by visiting
preloaded-expect-ct.badssl.com in Chrome and seeing that a report gets
generated and logged on the server side.

BUG=
==========

to

==========
Use the Google report-uri for badssl Expect-CT site

This change goes along with
https://github.com/chromium/badssl.com/pull/206, which adds the
preloaded-expect-ct.badssl.com to badssl.com and serves the Expect-CT
header with no SCTs. Along with this CL, we'll get an easy way to
manually test Expect-CT end-to-end, by visiting
preloaded-expect-ct.badssl.com in Chrome and seeing that a report gets
generated and logged on the server side.

BUG=

Committed: https://crrev.com/960fde37768267fb16f8b7ffd7bc4d4bac10bb4c
Cr-Commit-Position: refs/heads/master@{#418425}
==========

[commit-bot: I haz the power, 2016-09-14 00:09:13]

Patchset 3 (id:??) landed as
https://crrev.com/960fde37768267fb16f8b7ffd7bc4d4bac10bb4c
Cr-Commit-Position: refs/heads/master@{#418425}