Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233633003: Cleanup a TODO and other nits in SocketApiTest. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Cleanup a TODO and other nits in SocketApiTest. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M chrome/browser/extensions/api/socket/socket_apitest.cc View 11 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-10 19:43:03 UTC) #1
dmichael (off chromium)
lgtm
6 years, 8 months ago (2014-04-10 20:29:25 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-10 20:51:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/233633003/1
6 years, 8 months ago (2014-04-10 20:52:26 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 00:44:54 UTC) #5
Message was sent while issue was closed. 
Change committed as 263148

Powered by Google App Engine
This is Rietveld 408576698