Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2336303002: [V8][Wasm] Removes references to finally in wasm. (Closed)

Created:
4 years, 3 months ago by John
Modified:
4 years, 3 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8][Wasm] Removes references to finally in wasm. The initial support for low level exception handling in Wasm will not support finally blocks. This decision is taken for both simplicity ( handling finallys is not straightforward if we want try blocks to yield values), and lack of good use case (clang++ does not need them.) They may be added in the future once we understand the implications of having them. BUG= Committed: https://crrev.com/ee8ae932b875a236f9d9c0763a4c54afadf65751 Cr-Commit-Position: refs/heads/master@{#39393}

Patch Set 1 #

Patch Set 2 : git pull #

Patch Set 3 : updates comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -196 lines) Patch
M src/wasm/ast-decoder.cc View 1 2 13 chunks +38 lines, -124 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +1 line, -4 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 3 chunks +6 lines, -68 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
John
4 years, 3 months ago (2016-09-13 17:47:43 UTC) #4
bradnelson
lgtm
4 years, 3 months ago (2016-09-13 20:22:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336303002/40001
4 years, 3 months ago (2016-09-13 20:22:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 20:47:16 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 20:47:41 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee8ae932b875a236f9d9c0763a4c54afadf65751
Cr-Commit-Position: refs/heads/master@{#39393}

Powered by Google App Engine
This is Rietveld 408576698