Updating swarming api to check for chartjson results from a finished

scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json

Index: scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
diff --git a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
index d8854df33ff2c00edda458fb0d700685155558ef..58dce998c2424a84ee666237599cdc466e39adef 100644
--- a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
+++ b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
@@ -371,9 +371,7 @@
       "slavename:TestSlavename",
       "--tag",
       "stepname:telemetry_gpu_unittests on Ubuntu-12.04",
-      "eeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
-      "--",
-      "--isolated-script-test-output=${ISOLATED_OUTDIR}/output.json"
+      "eeeeeeeeeeeeeeeeeeeeeeeeeeeeee"
     ],
     "env": {
       "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
@@ -421,13 +419,18 @@
     "name": "telemetry_gpu_unittests on Ubuntu-12.04",
     "~followup_annotations": [
       "step returned non-zero exit code: 1",
-      "@@@STEP_TEXT@<br/>failures:<br/>test1.Test1<br/>test2.Test2<br/>test3.Test3<br/>test4.Test4<br/>@@@",
       "@@@STEP_LOG_LINE@outdir_json@{@@@",
+      "@@@STEP_LOG_LINE@outdir_json@  \"0/chartjson-output.json\": \"{\\\"dummy\\\": \\\"dummy0\\\", \\\"charts\\\": \\\"chart0\\\"}\", @@@",
       "@@@STEP_LOG_LINE@outdir_json@  \"0/output.json\": \"{\\\"successes\\\": [], \\\"failures\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"valid\\\": true, \\\"times\\\": {\\\"test2.Test2\\\": 0.1, \\\"test1.Test1\\\": 0.1}}\", @@@",
+      "@@@STEP_LOG_LINE@outdir_json@  \"1/chartjson-output.json\": \"{\\\"dummy\\\": \\\"dummy1\\\", \\\"charts\\\": \\\"chart1\\\"}\", @@@",
       "@@@STEP_LOG_LINE@outdir_json@  \"1/output.json\": \"{\\\"successes\\\": [], \\\"failures\\\": [\\\"test3.Test3\\\", \\\"test4.Test4\\\"], \\\"valid\\\": true, \\\"times\\\": {\\\"test3.Test3\\\": 0.1, \\\"test4.Test4\\\": 0.1}}\", @@@",
       "@@@STEP_LOG_LINE@outdir_json@  \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": true}, {\\\"internal_failure\\\": false, \\\"failure\\\": true}]}\"@@@",
       "@@@STEP_LOG_LINE@outdir_json@}@@@",
       "@@@STEP_LOG_END@outdir_json@@@",
+      "@@@STEP_LOG_LINE@no_results_exc@'str' object has no attribute 'extend'@@@",

[Ken Russell (switch to Gerrit), 2016/09/17 03:33:46]

This exception looks problematic. It shows up in a couple of other places below
too.

[eyaich1, 2016/09/19 17:56:16]

Done.

+      "@@@STEP_LOG_END@no_results_exc@@@",
+      "@@@STEP_LOG_LINE@invalid_results_exc@'failures'@@@",
+      "@@@STEP_LOG_END@invalid_results_exc@@@",
       "@@@STEP_LINK@shard #0@https://chromium-swarm.appspot.com/user/task/10000@@@",
       "@@@STEP_LINK@shard #1@https://chromium-swarm.appspot.com/user/task/10100@@@",
       "@@@STEP_FAILURE@@@"