Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: scripts/slave/recipes/chromium.py

Issue 2336293002: Updating swarming api to check for chartjson results from a finished (Closed)
Patch Set: Relanding CL Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index e99692d735ea450b560a11813dbc5788a8e544ed..a1705475be7beffa40ad7bc91889894f935492b6 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -491,7 +491,8 @@ def GenTests(api):
api.override_step_data('telemetry_gpu_unittests on Ubuntu-12.04',
api.test_utils.canned_isolated_script_output(
passing=True, is_win=False, swarming=True,
- shards=2, isolated_script_passing=True, valid=True),
+ shards=2, isolated_script_passing=True, valid=True,
+ output_chartjson=True),
retcode=0)
)
@@ -599,6 +600,77 @@ def GenTests(api):
)
yield (
+ api.test(
+ 'dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data(
+ 'read test spec (chromium.linux.json)',
+ api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {
+ 'can_use_on_swarming_builders': True,
+ 'shards': 2,
+ },
+ },
+ ],
+ },
+ })
+ ) +
+ api.override_step_data(
+ 'telemetry_gpu_unittests on Ubuntu-12.04',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ shards=4, isolated_script_passing=True, valid=True,
+ empty_shards=[1], output_chartjson=True),
+ retcode=1)
+ )
+
+ yield (
+ api.test('dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard') +
+ api.properties.generic(mastername='chromium.linux',
+ buildername='Linux Tests',
+ parent_buildername='Linux Builder') +
+ api.properties(swarm_hashes={
+ 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
+ }) +
+ api.platform('linux', 64) +
+ api.override_step_data(
+ 'read test spec (chromium.linux.json)',
+ api.json.output({
+ 'Linux Tests': {
+ 'isolated_scripts': [
+ {
+ 'isolate_name': 'telemetry_gpu_unittests',
+ 'name': 'telemetry_gpu_unittests',
+ 'swarming': {
+ 'can_use_on_swarming_builders': True,
+ 'shards': 2,
+ },
+ },
+ ],
+ },
+ })
+ ) +
+ api.override_step_data(
+ 'telemetry_gpu_unittests on Ubuntu-12.04',
+ api.test_utils.canned_isolated_script_output(
+ passing=True, is_win=False, swarming=True,
+ shards=2, isolated_script_passing=True, valid=True,
+ missing_shards=[1], output_chartjson=True),
+ retcode=1)
+ )
+
+ yield (
api.test('dynamic_swarmed_isolated_script_test_linux_gpu') +
api.properties.generic(mastername='chromium.linux',
buildername='Linux Tests',

Powered by Google App Engine
This is Rietveld 408576698