scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json - Issue 2336293002: Updating swarming api to check for chartjson results from a finished

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json

Issue 2336293002: Updating swarming api to check for chartjson results from a finished (Closed)

Patch Set: Removing debug logging Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/test_utils/test_api.py ('K') | « scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json ('k') | scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json

index 9822ffbac8d22b33f0f9516d40997ddbc3edcd00..74a5c417ae33f03085bd76ad16210d76b18ad4a3 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json

@@ -372,7 +372,8 @@

"stepname:telemetry_gpu_unittests on Ubuntu-12.04",

"eeeeeeeeeeeeeeeeeeeeeeeeeeeeee",

"--",

- "--isolated-script-test-output=${ISOLATED_OUTDIR}/output.json"

+ "--isolated-script-test-output=${ISOLATED_OUTDIR}/output.json",

+ "--isolated-script-test-chartjson-output=${ISOLATED_OUTDIR}/chartjson-output.json"

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

@@ -415,6 +416,7 @@

"~followup_annotations": [

"step returned non-zero exit code: 255",

"@@@STEP_LOG_LINE@outdir_json@{@@@",

+ "@@@STEP_LOG_LINE@outdir_json@ \"0/chartjson-output.json\": \"{\\\"dummy\\\": \\\"dummy0\\\", \\\"charts\\\": [{\\\"entry2\\\": \\\"chart2\\\", \\\"entry1\\\": \\\"chart1\\\"}]}\", @@@",

"@@@STEP_LOG_LINE@outdir_json@ \"0/output.json\": \"{\\\"successes\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"failures\\\": [], \\\"valid\\\": true, \\\"times\\\": {\\\"test2.Test2\\\": 0.1, \\\"test1.Test1\\\": 0.1}}\", @@@",

"@@@STEP_LOG_LINE@outdir_json@ \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": false}]}\"@@@",

"@@@STEP_LOG_LINE@outdir_json@}@@@",