Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2336233006: [wasm] C++ style: ErrorThrower& -> ErrorThrower* (Closed)

Created:
4 years, 3 months ago by Mircea Trofin
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] C++ style: ErrorThrower& -> ErrorThrower* All parameters passed by reference must be labeled const. If the object is mutable, then we pass by pointer. https://google.github.io/styleguide/cppguide.html#Reference_Arguments BUG= Committed: https://crrev.com/f87dfb8135e36bb01fc736bbb2684877b526f6f5 Cr-Commit-Position: refs/heads/master@{#39451}

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -44 lines) Patch
M src/wasm/wasm-module.cc View 1 4 chunks +14 lines, -13 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/common/wasm/wasm-module-runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 8 chunks +22 lines, -21 lines 0 comments Download
M test/fuzzer/wasm-code.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/fuzzer/wasm-section-fuzzers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
Mircea Trofin
4 years, 3 months ago (2016-09-14 16:37:21 UTC) #7
ahaas
lgtm
4 years, 3 months ago (2016-09-15 16:13:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336233006/20001
4 years, 3 months ago (2016-09-15 16:17:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 16:19:55 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 16:20:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f87dfb8135e36bb01fc736bbb2684877b526f6f5
Cr-Commit-Position: refs/heads/master@{#39451}

Powered by Google App Engine
This is Rietveld 408576698