chrome/browser/ui/cocoa/location_bar/button_decoration.h - Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/button_decoration.h

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixes tests. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm ('K') | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm ('k') | chrome/browser/ui/cocoa/location_bar/button_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/button_decoration.h

diff --git a/chrome/browser/ui/cocoa/location_bar/button_decoration.h b/chrome/browser/ui/cocoa/location_bar/button_decoration.h

index 3810637b26b50c9f56bd27f37ea27131095ad21f..3306721077e34aa911a94c65ab97c09e799c1005 100644

--- a/chrome/browser/ui/cocoa/location_bar/button_decoration.h

+++ b/chrome/browser/ui/cocoa/location_bar/button_decoration.h

@@ -38,6 +38,10 @@ class ButtonDecoration : public LocationBarDecoration {

void SetButtonState(ButtonState state);

ButtonState GetButtonState() const;

+ // Whether a click on this decoration should prevent focusing of the omnibox

+ // or not.

+ virtual bool PreventFocus(NSPoint location) const;

// Changes the icon for the specified button state only.

void SetIcon(ButtonState state, int icon_id);

@@ -57,7 +61,7 @@ class ButtonDecoration : public LocationBarDecoration {

virtual void DrawInFrame(NSRect frame, NSView* control_view) OVERRIDE;

virtual bool AcceptsMousePress() OVERRIDE;

virtual bool IsDraggable() OVERRIDE;

- virtual bool OnMousePressed(NSRect frame) OVERRIDE;

+ virtual bool OnMousePressed(NSRect frame, NSPoint location) OVERRIDE;

virtual ButtonDecoration* AsButtonDecoration() OVERRIDE;

private: