Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3429)

Unified Diff: chrome/browser/ui/toolbar/toolbar_model_impl.cc

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_model_impl.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_model_impl.cc b/chrome/browser/ui/toolbar/toolbar_model_impl.cc
index 92e9707296b15ce334e1f82360cc0302bd29ba97..94ad48f212d1eeba52139807607e48acaf8e9a58 100644
--- a/chrome/browser/ui/toolbar/toolbar_model_impl.cc
+++ b/chrome/browser/ui/toolbar/toolbar_model_impl.cc
@@ -51,6 +51,7 @@ ToolbarModelImpl::ToolbarModelImpl(ToolbarModelDelegate* delegate)
ToolbarModelImpl::~ToolbarModelImpl() {
}
+// static
ToolbarModel::SecurityLevel ToolbarModelImpl::GetSecurityLevelForWebContents(
content::WebContents* web_contents) {
if (!web_contents)
@@ -94,6 +95,19 @@ ToolbarModel::SecurityLevel ToolbarModelImpl::GetSecurityLevelForWebContents(
}
}
+// static
+base::string16 ToolbarModelImpl::GetEVCertName(
+ const net::X509Certificate& cert) {
+ // EV are required to have an organization name and country.
+ DCHECK(!cert.subject().organization_names.empty());
+ DCHECK(!cert.subject().country_name.empty());
+
+ return l10n_util::GetStringFUTF16(
+ IDS_SECURE_CONNECTION_EV,
+ base::UTF8ToUTF16(cert.subject().organization_names[0]),
+ base::UTF8ToUTF16(cert.subject().country_name));
+}
+
// ToolbarModelImpl Implementation.
base::string16 ToolbarModelImpl::GetText() const {
base::string16 search_terms(GetSearchTerms(false));
@@ -154,85 +168,11 @@ GURL ToolbarModelImpl::GetURL() const {
return GURL(content::kAboutBlankURL);
}
-bool ToolbarModelImpl::WouldOmitURLDueToOriginChip() const {
- const char kInterstitialShownKey[] = "interstitial_shown";
-
- // When users type URLs and hit enter, continue to show those URLs until
- // the navigation commits or an interstitial is shown, because having the
- // omnibox clear immediately feels like the input was ignored.
- NavigationController* navigation_controller = GetNavigationController();
- if (navigation_controller) {
- NavigationEntry* pending_entry = navigation_controller->GetPendingEntry();
- if (pending_entry) {
- const NavigationEntry* visible_entry =
- navigation_controller->GetVisibleEntry();
- base::string16 unused;
- // Keep track that we've shown the origin chip on an interstitial so it
- // can be shown even after the interstitial was dismissed, to avoid
- // showing the chip, removing it and then showing it again.
- if (visible_entry &&
- visible_entry->GetPageType() == content::PAGE_TYPE_INTERSTITIAL &&
- !pending_entry->GetExtraData(kInterstitialShownKey, &unused))
- pending_entry->SetExtraData(kInterstitialShownKey, base::string16());
- const content::PageTransition transition_type =
- pending_entry->GetTransitionType();
- if ((transition_type & content::PAGE_TRANSITION_TYPED) != 0 &&
- !pending_entry->GetExtraData(kInterstitialShownKey, &unused))
- return false;
- }
- }
-
- if (!delegate_->InTabbedBrowser() || !ShouldDisplayURL() ||
- !url_replacement_enabled())
- return false;
-
- if (chrome::ShouldDisplayOriginChip())
- return true;
-
- const chrome::OriginChipV2Condition chip_condition =
- chrome::GetOriginChipV2Condition();
- return (chip_condition != chrome::ORIGIN_CHIP_V2_DISABLED) &&
- ((chip_condition != chrome::ORIGIN_CHIP_V2_ON_SRP) ||
- WouldPerformSearchTermReplacement(false));
-}
-
bool ToolbarModelImpl::WouldPerformSearchTermReplacement(
bool ignore_editing) const {
return !GetSearchTerms(ignore_editing).empty();
}
-bool ToolbarModelImpl::ShouldDisplayURL() const {
- // Note: The order here is important.
- // - The WebUI test must come before the extension scheme test because there
- // can be WebUIs that have extension schemes (e.g. the bookmark manager). In
- // that case, we should prefer what the WebUI instance says.
- // - The view-source test must come before the NTP test because of the case
- // of view-source:chrome://newtab, which should display its URL despite what
- // chrome://newtab says.
- NavigationController* controller = GetNavigationController();
- NavigationEntry* entry = controller ? controller->GetVisibleEntry() : NULL;
- if (entry) {
- if (entry->IsViewSourceMode() ||
- entry->GetPageType() == content::PAGE_TYPE_INTERSTITIAL) {
- return true;
- }
-
- GURL url = entry->GetURL();
- GURL virtual_url = entry->GetVirtualURL();
- if (url.SchemeIs(content::kChromeUIScheme) ||
- virtual_url.SchemeIs(content::kChromeUIScheme)) {
- if (!url.SchemeIs(content::kChromeUIScheme))
- url = virtual_url;
- return url.host() != chrome::kChromeUINewTabHost;
- }
- }
-
- if (chrome::IsInstantNTP(delegate_->GetActiveWebContents()))
- return false;
-
- return true;
-}
-
ToolbarModel::SecurityLevel ToolbarModelImpl::GetSecurityLevel(
bool ignore_editing) const {
// When editing, assume no security style.
@@ -281,20 +221,75 @@ base::string16 ToolbarModelImpl::GetEVCertName() const {
return GetEVCertName(*cert.get());
}
-// static
-base::string16 ToolbarModelImpl::GetEVCertName(
- const net::X509Certificate& cert) {
- // EV are required to have an organization name and country.
- if (cert.subject().organization_names.empty() ||
- cert.subject().country_name.empty()) {
- NOTREACHED();
- return base::string16();
+bool ToolbarModelImpl::ShouldDisplayURL() const {
+ // Note: The order here is important.
+ // - The WebUI test must come before the extension scheme test because there
+ // can be WebUIs that have extension schemes (e.g. the bookmark manager). In
+ // that case, we should prefer what the WebUI instance says.
+ // - The view-source test must come before the NTP test because of the case
+ // of view-source:chrome://newtab, which should display its URL despite what
+ // chrome://newtab says.
+ NavigationController* controller = GetNavigationController();
+ NavigationEntry* entry = controller ? controller->GetVisibleEntry() : NULL;
+ if (entry) {
+ if (entry->IsViewSourceMode() ||
+ entry->GetPageType() == content::PAGE_TYPE_INTERSTITIAL) {
+ return true;
+ }
+
+ GURL url = entry->GetURL();
+ GURL virtual_url = entry->GetVirtualURL();
+ if (url.SchemeIs(content::kChromeUIScheme) ||
+ virtual_url.SchemeIs(content::kChromeUIScheme)) {
+ if (!url.SchemeIs(content::kChromeUIScheme))
+ url = virtual_url;
+ return url.host() != chrome::kChromeUINewTabHost;
+ }
}
- return l10n_util::GetStringFUTF16(
- IDS_SECURE_CONNECTION_EV,
- base::UTF8ToUTF16(cert.subject().organization_names[0]),
- base::UTF8ToUTF16(cert.subject().country_name));
+ return !chrome::IsInstantNTP(delegate_->GetActiveWebContents());
+}
+
+bool ToolbarModelImpl::WouldOmitURLDueToOriginChip() const {
+ const char kInterstitialShownKey[] = "interstitial_shown";
+
+ // When users type URLs and hit enter, continue to show those URLs until
+ // the navigation commits or an interstitial is shown, because having the
+ // omnibox clear immediately feels like the input was ignored.
+ NavigationController* navigation_controller = GetNavigationController();
+ if (navigation_controller) {
+ NavigationEntry* pending_entry = navigation_controller->GetPendingEntry();
+ if (pending_entry) {
+ const NavigationEntry* visible_entry =
+ navigation_controller->GetVisibleEntry();
+ base::string16 unused;
+ // Keep track that we've shown the origin chip on an interstitial so it
+ // can be shown even after the interstitial was dismissed, to avoid
+ // showing the chip, removing it and then showing it again.
+ if (visible_entry &&
+ visible_entry->GetPageType() == content::PAGE_TYPE_INTERSTITIAL &&
+ !pending_entry->GetExtraData(kInterstitialShownKey, &unused))
+ pending_entry->SetExtraData(kInterstitialShownKey, base::string16());
+ const content::PageTransition transition_type =
+ pending_entry->GetTransitionType();
+ if ((transition_type & content::PAGE_TRANSITION_TYPED) != 0 &&
+ !pending_entry->GetExtraData(kInterstitialShownKey, &unused))
+ return false;
+ }
+ }
+
+ if (!delegate_->InTabbedBrowser() || !ShouldDisplayURL() ||
+ !url_replacement_enabled())
+ return false;
+
+ if (chrome::ShouldDisplayOriginChip())
+ return true;
+
+ const chrome::OriginChipV2Condition chip_condition =
+ chrome::GetOriginChipV2Condition();
+ return (chip_condition != chrome::ORIGIN_CHIP_V2_DISABLED) &&
+ ((chip_condition != chrome::ORIGIN_CHIP_V2_ON_SRP) ||
+ WouldPerformSearchTermReplacement(false));
}
NavigationController* ToolbarModelImpl::GetNavigationController() const {
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_model_impl.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698