Shows the info bubble when the location bar icon is clicked in the origin chip.

chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h

Index: chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h
diff --git a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h
index 2b0fee9974a9b194970cb5bfe697094b6a856442..405260885719a6caa46d6109276193d1866aab07 100644
--- a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h
+++ b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.h
@@ -14,6 +14,7 @@
 #include "chrome/browser/ui/toolbar/origin_chip_info.h"
 
 class LocationBarViewMac;
+class LocationIconDecoration;
 
 namespace content {
 class WebContents;
@@ -26,17 +27,22 @@ class OriginChipDecoration : public ButtonDecoration,
                              public extensions::IconImage::Observer,
                              public SafeBrowsingUIManager::Observer {
  public:
-  explicit OriginChipDecoration(LocationBarViewMac* owner);
+  OriginChipDecoration(LocationBarViewMac* owner,
+                       LocationIconDecoration* location_icon);
   virtual ~OriginChipDecoration();
 
   // Updates the origin chip's content, and display state.
   void Update();
 
+  // Implement |ButtonDecoration|.
+  virtual bool PreventFocus(NSPoint location) const OVERRIDE;
+
   // Implement |LocationBarDecoration|.
   virtual CGFloat GetWidthForSpace(CGFloat width) OVERRIDE;
   virtual void DrawInFrame(NSRect frame, NSView* control_view) OVERRIDE;
   virtual NSString* GetToolTip() OVERRIDE;
-  virtual bool OnMousePressed(NSRect frame) OVERRIDE;
+  virtual bool OnMousePressed(NSRect frame, NSPoint location) OVERRIDE;
+  virtual NSPoint GetBubblePointInFrame(NSRect frame) OVERRIDE;
 
   // Implement |IconImage::Observer|.
   virtual void OnExtensionIconImageChanged(
@@ -49,9 +55,6 @@ class OriginChipDecoration : public ButtonDecoration,
       const SafeBrowsingUIManager::UnsafeResource& resource) OVERRIDE;
 
  private:
-  // Returns whether the origin chip should be shown or not.
-  bool ShouldShow() const;
-
   // Contains attributes for drawing the origin string.
   base::scoped_nsobject<NSMutableDictionary> attributes_;
 
@@ -59,12 +62,19 @@ class OriginChipDecoration : public ButtonDecoration,
   // extension.
   base::scoped_nsobject<NSImage> extension_icon_;
 
+  // The rectangle where the icon was last drawn. Used for hit testing to
+  // display the permissions bubble.
+  NSRect icon_rect_;
+
   // Manages information to be displayed on the origin chip.
   OriginChipInfo info_;
 
   // The label currently displayed in the chip.
   base::scoped_nsobject<NSString> label_;
 
+  // The location icon decoration. Weak.
+  LocationIconDecoration* location_icon_;

[Scott Hess - ex-Googler, 2014/05/08 23:00:47]

This dependency ever-so-slightly concerns me.  I can see why it is, and why
EvBubbleDecoration has it, but now it's in two places and I start to wonder if
it should be some other way entirely.  This class has owner_, the ev bubble
doesn't, but maybe owner_ dependency is more sane than depending directly on the
innards of a different decoration?  Or maybe it's time to lift the shared code
some other way?

Probably outside the scope of this CL, though.

[groby-ooo-7-16, 2014/05/08 23:14:07]

I made the same point further up - search for "I'm really queasy about the idea
of decorations depending on each other."

I'd suggest definitely doing this, in a follow-up CL.

[Scott Hess - ex-Googler, 2014/05/08 23:21:36]

I think my overall goal would be to make sure things stay pretty modular, and
not encourage everything to start relying on everything else.  I would guess
that's why I had the ev bubble depends on the decoration, to discourage people
from reaching through a juicy owner_ for additional state.

In the long term, it's plausible that this will simply display the ev bubble and
inline the location icon code entirely, in which case this concern will fall
away naturally.  In that case, I would actually prefer to not lard up
location_bar_view_mac.mm any further than it already is.

[All this said - mostly I just have opinions over here, so I'm also open to the
notion of having other opinionated people adding to a consensus to spread the
joy.]

[macourteau, 2014/05/09 14:00:27]

Yes, I agree. There's a TODO in LocationIconDecoration to address this:

  // TODO(macourteau): this code (for displaying the page info bubble) should be
  // pulled out into LocationBarViewMac (or maybe even further), as other
  // decorations currently depend on this decoration only to show the page info
  // bubble.

+
   // The control view that owns this. Weak.
   LocationBarViewMac* owner_;