chrome/browser/ui/views/location_bar/origin_chip_view.cc - Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/origin_chip_view.cc

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addresses nits from groby@. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/origin_chip_view.cc

diff --git a/chrome/browser/ui/views/location_bar/origin_chip_view.cc b/chrome/browser/ui/views/location_bar/origin_chip_view.cc

index dd6c82f563fe7b1b9bd76851cb3b870dfce3c9a5..c8fd54241c537c8557b6d88de5af53f01a9783e0 100644

--- a/chrome/browser/ui/views/location_bar/origin_chip_view.cc

+++ b/chrome/browser/ui/views/location_bar/origin_chip_view.cc

@@ -170,9 +170,7 @@ OriginChipView::~OriginChipView() {

}

bool OriginChipView::ShouldShow() {

- return chrome::ShouldDisplayOriginChipV2() &&

- location_bar_view_->GetToolbarModel()->WouldOmitURLDueToOriginChip() &&

- location_bar_view_->GetToolbarModel()->origin_chip_enabled();

+ return location_bar_view_->GetToolbarModel()->ShouldShowOriginChip();

Peter Kasting 2014/05/05 22:39:04 Let's eliminate ShouldShow() entirely and have cal

macourteau 2014/05/08 21:35:55 Done.

}

void OriginChipView::Update(content::WebContents* web_contents) {

« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « chrome/browser/ui/toolbar/toolbar_model_impl.cc ('k') | no next file » | no next file with comments »