Shows the info bubble when the location bar icon is clicked in the origin chip.

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_logging.h"
 #include "chrome/browser/search/search.h"
@@ skipping 474 matching lines @@
                                source:self
                             slideBack:YES];
 
       return YES;
     }
 
     // On mouse-up fall through to mouse-pressed case.
     DCHECK_EQ([event type], NSLeftMouseUp);
   }
 
+  // Figure out where the click happened inside the decoration.
+  const NSPoint mouseLocation =
+      [controlView convertPoint:[[NSApp currentEvent] locationInWindow]

[groby-ooo-7-16, 2014/04/10 21:26:09]

Why not use the current event that you already have? Also, why use the mousedown
location? Standard behavior is mouseUp triggers clicks.

[macourteau, 2014/04/28 19:19:24]

Done and Done. :)

+                       fromView:nil];
+  const NSPoint clickLocation = { mouseLocation.x - decorationRect.origin.x,
+                                  mouseLocation.y - decorationRect.origin.y };
+
   bool handled;
   if (decoration->AsButtonDecoration()) {
     ButtonDecoration* button = decoration->AsButtonDecoration();
 
     button->SetButtonState(ButtonDecoration::kButtonStatePressed);
     [controlView setNeedsDisplay:YES];
 
     // Track the mouse until the user releases the button.
     [self trackMouse:theEvent
               inRect:cellFrame
               ofView:controlView
         untilMouseUp:YES];
 
-    // Post delayed focus notification, if necessary.
-    if (focusEvent.get())
-      [self focusNotificationFor:focusEvent ofView:controlView];

[groby-ooo-7-16, 2014/04/10 21:26:09]

The focus notification should always happen before we do the click event. (I
wish I recalled exactly why, but there were issues around that)

It also should only happen if the button is clicked, not if there's no click.

[macourteau, 2014/04/28 19:19:24]

Hmm, the problem I'm having is that when the chip is set to hide-on-click, I
have no way to figure out if the click was on the location icon or on the rest
of the chip, and sending the focus notification ends up here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
which hides the chip because the mode is hide-on-click.

Suggestions?

[groby-ooo-7-16, 2014/04/30 21:55:39]

All suggestions are going to amount to evil hackery. We're doing things the
location icons weren't built for.

To quote from the original code review[1]: "...focus event needs to happen
before the ButtonDecoration gets the OnMousePressed (otherwise, the order of
events is wrong, and the decoration would get OnSetFocus after
OnMousePressed)..."

If you move it after the OnMousePressed, this is exactly what we'll encounter.

The least convoluted solution is probably checking inside the button's
OnSetFocus if it's the location icon, and not treat it as a hide-on-click in
that case.

[1] https://codereview.chromium.org/163913011

[macourteau, 2014/05/01 19:04:48]

The "PreventFocus" trick seems to work. The only potentially confusing
side-effect (which wasn't the case with the set_focused_... implementation) is
if you click the icon to show the bubble, then close the bubble but leave the
omnibox focused (chip still shows), then switch to another tab and switch back
to the previous tab. In that case, the omnibox will be focused but the chip is
gone (since the OmniboxEditModel doesn't know how the omnibox was focused, so it
hides the chip). Not sure if that's really an issue though :)

-
     // Set the proper state (hover or normal) once the mouse has been released,
     // and call |OnMousePressed| if the button was released while the mouse was
     // within the bounds of the button.
     const NSPoint mouseLocation = [[NSApp currentEvent] locationInWindow];
     const NSPoint point = [controlView convertPoint:mouseLocation fromView:nil];
     if (NSMouseInRect(point, decorationRect, [controlView isFlipped])) {
       button->SetButtonState(ButtonDecoration::kButtonStateHover);
       [controlView setNeedsDisplay:YES];
       handled = decoration->AsButtonDecoration()->OnMousePressed(
-          [self frameForDecoration:decoration inFrame:cellFrame]);
+          [self frameForDecoration:decoration inFrame:cellFrame],
+          clickLocation);
     } else {
       button->SetButtonState(ButtonDecoration::kButtonStateNormal);
       [controlView setNeedsDisplay:YES];
       handled = true;
     }
+
+    // Post delayed focus notification, if necessary, after calling the button's
+    // |OnMousePressed|.
+    if (focusEvent.get())
+      [self focusNotificationFor:focusEvent ofView:controlView];
   } else {
-    handled = decoration->OnMousePressed(decorationRect);
+    handled = decoration->OnMousePressed(decorationRect, clickLocation);
   }
 
   return handled ? YES : NO;
 }
 
 // Helper method for the |mouseEntered:inView:| and |mouseExited:inView:|
 // messages. Retrieves the |ButtonDecoration| for the specified event (received
 // from a tracking area), and returns |NULL| if no decoration matches.
 - (ButtonDecoration*)getButtonDecorationForEvent:(NSEvent*)theEvent {
   ButtonDecoration* bd = static_cast<ButtonDecoration*>(
@@ skipping 316 matching lines @@
       focusEvent_.reset([event retain]);
       return;
     }
   }
 
   // Handle event immediately.
   [self focusNotificationFor:event ofView:controlView];
 }
 
 @end