Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/findbugs_diff.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/BUILD.gn ('k') | build/android/gn/zip.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/findbugs_diff.py
diff --git a/build/android/findbugs_diff.py b/build/android/findbugs_diff.py
index 9a92b3a9b0d9017c96bce7df3a33d6d899f884e7..541cef1ba745cc53187ee75f048fff3d8843f693 100755
--- a/build/android/findbugs_diff.py
+++ b/build/android/findbugs_diff.py
@@ -105,10 +105,8 @@ def main():
print
else:
if args.depfile:
- build_utils.WriteDepfile(
- args.depfile,
- build_utils.GetPythonDependencies() + args.auxclasspath
- + args.jar_paths)
+ deps = args.auxclasspath + args.jar_paths
+ build_utils.WriteDepfile(args.depfile, args.output_file, deps)
if args.stamp:
build_utils.Touch(args.stamp)
« no previous file with comments | « build/android/BUILD.gn ('k') | build/android/gn/zip.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698