build/android/gyp/locale_pak_resources.py - Issue 2336173003: Fix android depfiles to always list GN's outputs[0]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/locale_pak_resources.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/locale_pak_resources.py

diff --git a/build/android/gyp/locale_pak_resources.py b/build/android/gyp/locale_pak_resources.py

index 63d33431835a97aa71e469c3259768233306e20d..73f4405112a507c88e83447899f1123fcb2a063d 100755

--- a/build/android/gyp/locale_pak_resources.py

+++ b/build/android/gyp/locale_pak_resources.py

@@ -96,8 +96,8 @@ def main():

sources = build_utils.ParseGnList(options.locale_paks)

if options.depfile:

- deps = sources + build_utils.GetPythonDependencies()

- build_utils.WriteDepfile(options.depfile, deps)

+ assert options.resources_zip

+ build_utils.WriteDepfile(options.depfile, options.resources_zip, sources)

mappings, lang_to_locale_map = ComputeMappings(sources)

if options.print_languages: