Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3016)

Unified Diff: build/android/gyp/create_dist_jar.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/create_dist_jar.py
diff --git a/build/android/gyp/create_dist_jar.py b/build/android/gyp/create_dist_jar.py
index 582434f787e7aec80c00e693a2cb402a0c86f465..2206cc64ae98287af495f64f540ce0b127cda66e 100755
--- a/build/android/gyp/create_dist_jar.py
+++ b/build/android/gyp/create_dist_jar.py
@@ -27,9 +27,7 @@ def main(args):
build_utils.MergeZips(options.output, input_jars)
if options.depfile:
- build_utils.WriteDepfile(
- options.depfile,
- input_jars + build_utils.GetPythonDependencies())
+ build_utils.WriteDepfile(options.depfile, options.output, input_jars)
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698