Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2336143002: Warn about Web Audio without user gesture on Android no longer allowed on cross origin iframes. (Closed)

Created:
4 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Warn about Web Audio without user gesture on Android no longer allowed on cross origin iframes. This is a CL to send to M54 to warn users of Web Audio in cross origin iframes. Note that because of how Web Audio work this warning (and the use counter) are larger than reality: every `new AudioContext` in a cross origin iframe will warn if not inside an event handler even if they are not meant to be used yet. Intent to Intervene: https://groups.google.com/a/chromium.org/d/msg/blink-dev/51WbTwn0M_Y/VZuwn8-VAAAJ BUG=617090 Review-Url: https://codereview.chromium.org/2311233002 Cr-Commit-Position: refs/heads/master@{#418201} (cherry picked from commit 8e94d8acbaf7ffca80e06429422fe8cbd311f781) Committed: https://chromium.googlesource.com/chromium/src/+/2fb1bdf0ffe1d08ed7ec098de07daf59447a1903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years, 3 months ago (2016-09-13 09:19:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2fb1bdf0ffe1d08ed7ec098de07daf59447a1903.

Powered by Google App Engine
This is Rietveld 408576698