Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2336113002: [turbofan] Make the inlining heuristic deterministic. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make the inlining heuristic deterministic. Don't sort inline candidates by comparing Node pointers, where the order depends on the allocation order and the concrete Zone memory layout at runtime. Instead sort based on NodeId, which is deterministic. R=mvstanton@chromium.org BUG=v8:5267 Committed: https://crrev.com/ae9a39b010ff74759439d3084e99a6b809085151 Cr-Commit-Position: refs/heads/master@{#39371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-13 07:53:26 UTC) #1
Benedikt Meurer
Hey Michael, Here's a fix for some of the non-determinism we see with for example ...
4 years, 3 months ago (2016-09-13 07:54:06 UTC) #4
mvstanton
Yay predictability. lgtm. :)
4 years, 3 months ago (2016-09-13 07:58:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336113002/1
4 years, 3 months ago (2016-09-13 07:58:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 08:19:26 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 08:19:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae9a39b010ff74759439d3084e99a6b809085151
Cr-Commit-Position: refs/heads/master@{#39371}

Powered by Google App Engine
This is Rietveld 408576698