WebCrypto: properly normalize optional numeric parameters.

Source/bindings/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 85 matching lines @@
     bool get(const String&, RefPtr<VoidCallback>&) const;
     bool get(const String&, v8::Local<v8::Value>&) const;
 
     bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
     bool getOwnPropertyNames(Vector<String>&) const;
 
     bool getWithUndefinedOrNullCheck(const String&, String&) const;
 
     PassRefPtr<EventListener> getEventListener(const String&, Notification*) const { return 0; }
 
+    bool contains(const String&) const;

[abarth-chromium, 2013/08/23 19:25:50]

This is not a good idea.  The problem is that JavaScript object can behave
differently each time they are interrogated.  If you check that the Dictionary
contains a given key, that doesn't mean it will still have it when you actually
try to get the key.  The act of getting the key can mutate the dictionary.

You can't split the contains and get steps.  You have to do both at the same
time.  not lgtm.

[eroman, 2013/08/23 22:04:03]

Thanks. I have tried to address this, please take another look.

+
 private:
     bool getKey(const String& key, v8::Local<v8::Value>&) const;
 
     // This object can only be used safely when stack allocated because of v8::Local.
     static void* operator new(size_t);
     static void* operator new[](size_t);
     static void operator delete(void *);
 
     v8::Local<v8::Value> m_options;
     v8::Isolate* m_isolate;
 };
 
 }
 
 #endif // Dictionary_h