Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2336093002: [turbofan] Strength reduce CheckTaggedSigned/Pointer with checked inputs. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Strength reduce CheckTaggedSigned/Pointer with checked inputs. Add strength reduction rules to optimize CheckTaggedSigned(CheckTaggedSigned(x)) -> CheckTaggedSigned(x) and CheckTaggedPointer(CheckTaggedPointer(x)) -> CheckTaggedPointer(x) where we do some cleanup optimizations after loop peeling and redundancy elimination, which can generate these constructs. BUG=v8:5267 Committed: https://crrev.com/dfc4b47f661d7cde5fa23112c19e3f146526d0d3 Cr-Commit-Position: refs/heads/master@{#39366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M src/compiler/simplified-operator-reducer.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
Hey Michael, Simple optimization to cleanup after loop peeling/load elimination. Please take a look. Thanks, ...
4 years, 3 months ago (2016-09-13 06:23:29 UTC) #4
mvstanton
lgtm(lgtm) -> lgtm.
4 years, 3 months ago (2016-09-13 06:27:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336093002/1
4 years, 3 months ago (2016-09-13 06:27:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 06:31:57 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 06:32:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfc4b47f661d7cde5fa23112c19e3f146526d0d3
Cr-Commit-Position: refs/heads/master@{#39366}

Powered by Google App Engine
This is Rietveld 408576698