Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/domain_reliability/monitor.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Initialize new raw pointer. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor.cc
diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc
index 2da1d509dd17718e182f26708671c3a276199ec4..2ebc9d406bfcf5b76e1e9791c311177a58274b25 100644
--- a/components/domain_reliability/monitor.cc
+++ b/components/domain_reliability/monitor.cc
@@ -120,6 +120,8 @@ DomainReliabilityMonitor::~DomainReliabilityMonitor() {
DCHECK(OnPrefThread());
net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
+
+ DCHECK(!uploader_);
}
void DomainReliabilityMonitor::MoveToNetworkThread() {
@@ -155,6 +157,10 @@ void DomainReliabilityMonitor::InitURLRequestContext(
url_request_context_getter);
}
+void DomainReliabilityMonitor::Shutdown() {
+ uploader_.reset();
mmenke 2016/09/26 21:30:09 I don't see any checks for a null uploader anywher
Julia Tuttle 2016/09/27 16:49:59 Not sure, but fixed with new Shutdown.
+}
+
void DomainReliabilityMonitor::AddBakedInConfigs() {
DCHECK(OnNetworkThread());
DCHECK(moved_to_network_thread_);

Powered by Google App Engine
This is Rietveld 408576698