Domain Reliability: Don't crash on shutdown with uploads pending

chrome/browser/domain_reliability/browsertest.cc

Index: chrome/browser/domain_reliability/browsertest.cc
diff --git a/chrome/browser/domain_reliability/browsertest.cc b/chrome/browser/domain_reliability/browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1954b78c9c1e14ba79b3f3651a8854cee84c9fe8
--- /dev/null
+++ b/chrome/browser/domain_reliability/browsertest.cc
@@ -0,0 +1,101 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/domain_reliability/service_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "components/domain_reliability/service.h"
+#include "net/base/net_errors.h"
+#include "net/test/url_request/url_request_failed_job.h"
+#include "url/gurl.h"
+
+namespace domain_reliability {
+
+class DomainReliabilityBrowserTest : public InProcessBrowserTest {
+ public:
+  DomainReliabilityBrowserTest() {
+    net::URLRequestFailedJob::AddUrlHandler();
+  }
+
+  ~DomainReliabilityBrowserTest() override {}
+
+  // Note: In an ideal world, instead of appending the command-line switch and
+  // manually setting discard_uploads to false, Domain Reliability would
+  // continuously monitor the metrics reporting pref, and the test could just
+  // set the pref.
+
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kEnableDomainReliability);
+  }
+
+  void SetUpOnMainThread() override {
+    InProcessBrowserTest::SetUpOnMainThread();
+
+    DomainReliabilityService* service = GetService();
+    if (service)
+      service->SetDiscardUploadsForTesting(false);
+  }
+
+  DomainReliabilityService* GetService() {
+    return DomainReliabilityServiceFactory::GetForBrowserContext(
+        browser()->profile());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DomainReliabilityBrowserTest);
+};
+
+class DomainReliabilityDisabledBrowserTest
+    : public DomainReliabilityBrowserTest {
+ protected:
+  DomainReliabilityDisabledBrowserTest() {}
+
+  ~DomainReliabilityDisabledBrowserTest() override {}
+
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kDisableDomainReliability);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DomainReliabilityDisabledBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(DomainReliabilityDisabledBrowserTest,
+                       ServiceNotCreated) {
+  EXPECT_FALSE(GetService());
+}
+
+IN_PROC_BROWSER_TEST_F(DomainReliabilityBrowserTest, ServiceCreated) {
+  EXPECT_TRUE(GetService());
+}
+
+IN_PROC_BROWSER_TEST_F(DomainReliabilityBrowserTest, UploadAtShutdown) {
+  DomainReliabilityService* service = GetService();
+
+  auto config = base::MakeUnique<DomainReliabilityConfig>();
+  config->origin = GURL("https://localhost/");
+  config->include_subdomains = false;
+  config->collectors.push_back(new GURL(
+      net::URLRequestFailedJob::GetMockHttpsUrl(net::ERR_IO_PENDING)));
+  config->success_sample_rate = 1.0;
+  config->failure_sample_rate = 1.0;
+  service->AddContextForTesting(std::move(config));
+
+  ui_test_utils::NavigateToURL(browser(), GURL("https://localhost/"));
+
+  service->ForceUploadsForTesting();
+
+  // At this point, there is an upload pending. If everything goes well, the
+  // test will finish, destroy the profile, and Domain Reliability will shut
+  // down properly. If things go awry, it may crash as terminating the pending
+  // upload calls into already-destroyed parts of the component.
+}
+
+}  // namespace domain_reliability