Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/domain_reliability/monitor.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: No, really. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor.cc
diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc
index c789be780a97568bf069e2f3508149ef7b21634f..9c56882ecb4de1e6571e6e0b5eaf97cf999215c3 100644
--- a/components/domain_reliability/monitor.cc
+++ b/components/domain_reliability/monitor.cc
@@ -155,6 +155,10 @@ void DomainReliabilityMonitor::InitURLRequestContext(
url_request_context_getter);
}
+void DomainReliabilityMonitor::Shutdown() {
+ uploader_->Shutdown();
+}
+
void DomainReliabilityMonitor::AddBakedInConfigs() {
DCHECK(OnNetworkThread());
DCHECK(moved_to_network_thread_);
@@ -249,6 +253,10 @@ DomainReliabilityContext* DomainReliabilityMonitor::AddContextForTesting(
return context_manager_.AddContextForConfig(std::move(config));
}
+void DomainReliabilityMonitor::ForceUploadsForTesting() {
+ dispatcher_.RunAllTasksForTesting();
+}
+
std::unique_ptr<DomainReliabilityContext>
DomainReliabilityMonitor::CreateContextForConfig(
std::unique_ptr<const DomainReliabilityConfig> config) {

Powered by Google App Engine
This is Rietveld 408576698