Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/domain_reliability/monitor.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Shutdown uploader in unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor.cc
diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc
index 2da1d509dd17718e182f26708671c3a276199ec4..bd240dbb1169004a06359888edb9913779c29c08 100644
--- a/components/domain_reliability/monitor.cc
+++ b/components/domain_reliability/monitor.cc
@@ -155,6 +155,10 @@ void DomainReliabilityMonitor::InitURLRequestContext(
url_request_context_getter);
}
+void DomainReliabilityMonitor::Shutdown() {
+ uploader_->Shutdown();
mmenke 2016/09/27 16:56:15 If it can, we should have a test for it. If it ca
+}
+
void DomainReliabilityMonitor::AddBakedInConfigs() {
DCHECK(OnNetworkThread());
DCHECK(moved_to_network_thread_);

Powered by Google App Engine
This is Rietveld 408576698