Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Remove outdated comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/domain_reliability/browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
11 #include <memory> 11 #include <memory>
12 #include <set> 12 #include <set>
13 #include <string> 13 #include <string>
14 #include <vector> 14 #include <vector>
15 15
16 #include "base/bind.h" 16 #include "base/bind.h"
17 #include "base/bind_helpers.h" 17 #include "base/bind_helpers.h"
18 #include "base/files/file_path.h" 18 #include "base/files/file_path.h"
19 #include "base/files/file_util.h" 19 #include "base/files/file_util.h"
20 #include "base/guid.h" 20 #include "base/guid.h"
21 #include "base/location.h" 21 #include "base/location.h"
22 #include "base/logging.h"
22 #include "base/macros.h" 23 #include "base/macros.h"
23 #include "base/memory/ptr_util.h" 24 #include "base/memory/ptr_util.h"
24 #include "base/message_loop/message_loop.h" 25 #include "base/message_loop/message_loop.h"
25 #include "base/run_loop.h" 26 #include "base/run_loop.h"
26 #include "base/single_thread_task_runner.h" 27 #include "base/single_thread_task_runner.h"
27 #include "base/strings/utf_string_conversions.h" 28 #include "base/strings/utf_string_conversions.h"
28 #include "base/task/cancelable_task_tracker.h" 29 #include "base/task/cancelable_task_tracker.h"
29 #include "base/threading/thread_task_runner_handle.h" 30 #include "base/threading/thread_task_runner_handle.h"
30 #include "build/build_config.h" 31 #include "build/build_config.h"
31 #include "chrome/browser/autofill/personal_data_manager_factory.h" 32 #include "chrome/browser/autofill/personal_data_manager_factory.h"
(...skipping 846 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 last_clear_mode_ = clear_mode; 879 last_clear_mode_ = clear_mode;
879 last_filter_ = origin_filter; 880 last_filter_ = origin_filter;
880 callback.Run(); 881 callback.Run();
881 } 882 }
882 883
883 void GetWebUIData(const base::Callback<void(std::unique_ptr<base::Value>)>& 884 void GetWebUIData(const base::Callback<void(std::unique_ptr<base::Value>)>&
884 callback) const override { 885 callback) const override {
885 NOTREACHED(); 886 NOTREACHED();
886 } 887 }
887 888
889 void SetDiscardUploadsForTesting(bool discard_uploads) override {
890 NOTREACHED();
891 }
892
893 void AddContextForTesting(
894 std::unique_ptr<const domain_reliability::DomainReliabilityConfig> config)
895 override {
896 NOTREACHED();
897 }
898
899 void ForceUploadsForTesting() override { NOTREACHED(); }
900
888 int clear_count() const { return clear_count_; } 901 int clear_count() const { return clear_count_; }
889 902
890 DomainReliabilityClearMode last_clear_mode() const { 903 DomainReliabilityClearMode last_clear_mode() const {
891 return last_clear_mode_; 904 return last_clear_mode_;
892 } 905 }
893 906
894 const base::Callback<bool(const GURL&)>& last_filter() const { 907 const base::Callback<bool(const GURL&)>& last_filter() const {
895 return last_filter_; 908 return last_filter_;
896 } 909 }
897 910
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
3095 // There should be no recently visited bookmarks. 3108 // There should be no recently visited bookmarks.
3096 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks( 3109 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks(
3097 bookmark_model, 2, base::Time::UnixEpoch(), 3110 bookmark_model, 2, base::Time::UnixEpoch(),
3098 /*consider_visits_from_desktop=*/false), 3111 /*consider_visits_from_desktop=*/false),
3099 IsEmpty()); 3112 IsEmpty());
3100 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks( 3113 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks(
3101 bookmark_model, 2, base::Time::UnixEpoch(), 3114 bookmark_model, 2, base::Time::UnixEpoch(),
3102 /*consider_visits_from_desktop=*/true), 3115 /*consider_visits_from_desktop=*/true),
3103 IsEmpty()); 3116 IsEmpty());
3104 } 3117 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/domain_reliability/browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698