Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: components/domain_reliability/uploader.h

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: No, really. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_ 5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
6 #define COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_ 6 #define COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 // Returns true if the request originated from domain reliability uploader. 58 // Returns true if the request originated from domain reliability uploader.
59 static bool OriginatedFromDomainReliability(const net::URLRequest& request); 59 static bool OriginatedFromDomainReliability(const net::URLRequest& request);
60 60
61 // Uploads |report_json| to |upload_url| and calls |callback| when the upload 61 // Uploads |report_json| to |upload_url| and calls |callback| when the upload
62 // has either completed or failed. 62 // has either completed or failed.
63 virtual void UploadReport(const std::string& report_json, 63 virtual void UploadReport(const std::string& report_json,
64 int max_beacon_depth, 64 int max_beacon_depth,
65 const GURL& upload_url, 65 const GURL& upload_url,
66 const UploadCallback& callback) = 0; 66 const UploadCallback& callback) = 0;
67 67
68 virtual void Shutdown();
mmenke 2016/12/14 19:12:17 Needs a comment.
Julia Tuttle 2016/12/15 21:53:00 Done.
69
68 virtual void set_discard_uploads(bool discard_uploads) = 0; 70 virtual void set_discard_uploads(bool discard_uploads) = 0;
69 71
70 static int GetURLRequestUploadDepth(const net::URLRequest& request); 72 static int GetURLRequestUploadDepth(const net::URLRequest& request);
71 }; 73 };
72 74
73 } // namespace domain_reliability 75 } // namespace domain_reliability
74 76
75 #endif // COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_ 77 #endif // COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698