Domain Reliability: Don't crash on shutdown with uploads pending

components/domain_reliability/monitor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 70 matching lines @@
   // Initializes the Monitor's URLRequestContextGetter.
   //
   // Must be called on the network thread, after |MoveToNetworkThread|.
   void InitURLRequestContext(net::URLRequestContext* url_request_context);
 
   // Same, but for unittests where the Getter is readily available.
   void InitURLRequestContext(
       const scoped_refptr<net::URLRequestContextGetter>&
           url_request_context_getter);
 
+  void Shutdown();

[mmenke, 2016/12/14 19:12:17]

Needs description

[Julia Tuttle, 2016/12/15 21:53:00]

Done.

+
   // Populates the monitor with contexts that were configured at compile time.
   void AddBakedInConfigs();
 
   // Sets whether the uploader will discard uploads. Must be called after
   // |InitURLRequestContext|.
   void SetDiscardUploads(bool discard_uploads);
 
   // Should be called when |request| is about to follow a redirect. Will
   // examine and possibly log the redirect request. Must be called after
   // |SetDiscardUploads|.
@@ skipping 22 matching lines @@
   // debugging purposes.
   std::unique_ptr<base::Value> GetWebUIData() const;
 
   DomainReliabilityContext* AddContextForTesting(
       std::unique_ptr<const DomainReliabilityConfig> config);
 
   size_t contexts_size_for_testing() const {
     return context_manager_.contexts_size_for_testing();
   }
 
+  void ForceUploadsForTesting();

[mmenke, 2016/12/14 19:12:17]

Maybe add a comment?

[Julia Tuttle, 2016/12/15 21:53:00]

Done.

+
   // DomainReliabilityContext::Factory implementation:
   std::unique_ptr<DomainReliabilityContext> CreateContextForConfig(
       std::unique_ptr<const DomainReliabilityConfig> config) override;
 
  private:
   friend class DomainReliabilityMonitorTest;
   // Allow the Service to call |MakeWeakPtr|.
   friend class DomainReliabilityServiceImpl;
 
   typedef std::map<std::string, DomainReliabilityContext*> ContextMap;
@@ skipping 45 matching lines @@
   bool discard_uploads_set_;
 
   base::WeakPtrFactory<DomainReliabilityMonitor> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DomainReliabilityMonitor);
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_