Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: No, really. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 867 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 last_clear_mode_ = clear_mode; 878 last_clear_mode_ = clear_mode;
879 last_filter_ = origin_filter; 879 last_filter_ = origin_filter;
880 callback.Run(); 880 callback.Run();
881 } 881 }
882 882
883 void GetWebUIData(const base::Callback<void(std::unique_ptr<base::Value>)>& 883 void GetWebUIData(const base::Callback<void(std::unique_ptr<base::Value>)>&
884 callback) const override { 884 callback) const override {
885 NOTREACHED(); 885 NOTREACHED();
886 } 886 }
887 887
888 void SetDiscardUploadsForTesting(bool discard_uploads) override {
889 NOTREACHED();
mmenke 2016/12/14 19:12:17 include base/logging.h
Julia Tuttle 2016/12/15 21:52:59 Done.
890 }
891
892 void AddContextForTesting(
893 std::unique_ptr<const domain_reliability::DomainReliabilityConfig> config)
894 override {
895 NOTREACHED();
896 }
897
898 void ForceUploadsForTesting() override { NOTREACHED(); }
899
888 int clear_count() const { return clear_count_; } 900 int clear_count() const { return clear_count_; }
889 901
890 DomainReliabilityClearMode last_clear_mode() const { 902 DomainReliabilityClearMode last_clear_mode() const {
891 return last_clear_mode_; 903 return last_clear_mode_;
892 } 904 }
893 905
894 const base::Callback<bool(const GURL&)>& last_filter() const { 906 const base::Callback<bool(const GURL&)>& last_filter() const {
895 return last_filter_; 907 return last_filter_;
896 } 908 }
897 909
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
3095 // There should be no recently visited bookmarks. 3107 // There should be no recently visited bookmarks.
3096 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks( 3108 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks(
3097 bookmark_model, 2, base::Time::UnixEpoch(), 3109 bookmark_model, 2, base::Time::UnixEpoch(),
3098 /*consider_visits_from_desktop=*/false), 3110 /*consider_visits_from_desktop=*/false),
3099 IsEmpty()); 3111 IsEmpty());
3100 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks( 3112 EXPECT_THAT(ntp_snippets::GetRecentlyVisitedBookmarks(
3101 bookmark_model, 2, base::Time::UnixEpoch(), 3113 bookmark_model, 2, base::Time::UnixEpoch(),
3102 /*consider_visits_from_desktop=*/true), 3114 /*consider_visits_from_desktop=*/true),
3103 IsEmpty()); 3115 IsEmpty());
3104 } 3116 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/domain_reliability/browsertest.cc » ('j') | chrome/browser/domain_reliability/browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698