Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: components/domain_reliability/uploader_unittest.cc

Issue 2336043007: Domain Reliability: Don't crash on shutdown with uploads pending (Closed)
Patch Set: Shutdown uploader in unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/domain_reliability/uploader.h" 5 #include "components/domain_reliability/uploader.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 message_loop_.task_runner())), 190 message_loop_.task_runner())),
191 interceptor_(new UploadInterceptor()), 191 interceptor_(new UploadInterceptor()),
192 uploader_(DomainReliabilityUploader::Create( 192 uploader_(DomainReliabilityUploader::Create(
193 &time_, url_request_context_getter_)) { 193 &time_, url_request_context_getter_)) {
194 net::URLRequestFilter::GetInstance()->AddUrlInterceptor( 194 net::URLRequestFilter::GetInstance()->AddUrlInterceptor(
195 GURL(kUploadURL), base::WrapUnique(interceptor_)); 195 GURL(kUploadURL), base::WrapUnique(interceptor_));
196 uploader_->set_discard_uploads(false); 196 uploader_->set_discard_uploads(false);
197 } 197 }
198 198
199 ~DomainReliabilityUploaderTest() override { 199 ~DomainReliabilityUploaderTest() override {
200 uploader_->Shutdown();
200 net::URLRequestFilter::GetInstance()->ClearHandlers(); 201 net::URLRequestFilter::GetInstance()->ClearHandlers();
201 } 202 }
202 203
203 DomainReliabilityUploader* uploader() const { return uploader_.get(); } 204 DomainReliabilityUploader* uploader() const { return uploader_.get(); }
204 UploadInterceptor* interceptor() const { return interceptor_; } 205 UploadInterceptor* interceptor() const { return interceptor_; }
205 206
206 private: 207 private:
207 base::MessageLoopForIO message_loop_; 208 base::MessageLoopForIO message_loop_;
208 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_; 209 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
209 UploadInterceptor* interceptor_; 210 UploadInterceptor* interceptor_;
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 TestUploadCallback c; 274 TestUploadCallback c;
274 uploader()->UploadReport("{}", 1, GURL(kUploadURL), c.callback()); 275 uploader()->UploadReport("{}", 1, GURL(kUploadURL), c.callback());
275 base::RunLoop().RunUntilIdle(); 276 base::RunLoop().RunUntilIdle();
276 EXPECT_EQ(1u, c.called_count()); 277 EXPECT_EQ(1u, c.called_count());
277 278
278 EXPECT_EQ(2, interceptor()->last_upload_depth()); 279 EXPECT_EQ(2, interceptor()->last_upload_depth());
279 } 280 }
280 281
281 } // namespace 282 } // namespace
282 } // namespace domain_reliability 283 } // namespace domain_reliability
OLDNEW
« components/domain_reliability/uploader.cc ('K') | « components/domain_reliability/uploader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698