Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2336013002: ScrollRectToVisible should bubble up through its layout container. (Closed)
Patch Set: Bubbling up through the layout container. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-overflow-clip.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 8528d71253edfe1745b63b60d47b2ffeede3521e..1bb991963a5ab26d9b324a31554e501c4e62c994 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -575,9 +575,9 @@ void LayoutBox::scrollRectToVisible(const LayoutRect& rect, const ScrollAlignmen
LayoutRect newRect = rectToScroll;
bool restrictedByLineClamp = false;
- if (parent()) {
- parentBox = parent()->enclosingBox();
- restrictedByLineClamp = !parent()->style()->lineClamp().isNone();
+ if (container()) {
+ parentBox = container()->enclosingBox();
bokan 2016/09/15 20:54:41 I think we could use containingBlock rather than c
+ restrictedByLineClamp = !container()->style()->lineClamp().isNone();
}
if (hasOverflowClip() && !restrictedByLineClamp) {
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scrolling/absolute-position-overflow-clip.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698