change write-image to use pipeverbs like everyone else, and add test

change write-image to use pipeverbs like everyone else, and add test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003

Committed: https://skia.googlesource.com/skia/+/7e3ba9f88d64d901243799b61f497319e5970693

[reed1, 2016-09-13 20:20:15]

Description was changed from

==========
change write-image to use pipeverbs like everyone else, and add test

BUG=skia:
==========

to

==========
change write-image to use pipeverbs like everyone else, and add test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003
==========

[reed1, 2016-09-13 20:20:55]

reed@google.com changed reviewers:
+ mtklein@google.com

[reed1, 2016-09-13 20:21:01]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 20:21:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 21:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:21:46]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-09-13 21:24:52]

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp
File src/pipe/SkPipeCanvas.cpp (right):

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp#n...
src/pipe/SkPipeCanvas.cpp:1042: *  or
Might be simpler to think about if it's

if (!defined) {
   kDefinedImage + image_index
}
kWriteImage + image_index

So that you never have to think, sometimes define means define+write, sometimes
just define.

[reed1, 2016-09-13 23:11:34]

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp
File src/pipe/SkPipeCanvas.cpp (right):

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp#n...
src/pipe/SkPipeCanvas.cpp:1042: *  or
On 2016/09/13 21:24:52, mtklein wrote:
> Might be simpler to think about if it's
> 
> if (!defined) {
>    kDefinedImage + image_index
> }
> kWriteImage + image_index
> 
> So that you never have to think, sometimes define means define+write,
sometimes
> just define.

Seems like it actually complicates the reader, where today its a simple switch
statement. Do you still prefer this idea after looking at the reader?

[reed1, 2016-09-13 23:36:29]

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp
File src/pipe/SkPipeCanvas.cpp (right):

https://codereview.chromium.org/2335973003/diff/1/src/pipe/SkPipeCanvas.cpp#n...
src/pipe/SkPipeCanvas.cpp:1042: *  or
On 2016/09/13 23:11:34, reed1 wrote:
> On 2016/09/13 21:24:52, mtklein wrote:
> > Might be simpler to think about if it's
> > 
> > if (!defined) {
> >    kDefinedImage + image_index
> > }
> > kWriteImage + image_index
> > 
> > So that you never have to think, sometimes define means define+write,
> sometimes
> > just define.
> 
> Seems like it actually complicates the reader, where today its a simple switch
> statement. Do you still prefer this idea after looking at the reader?

I've uploaded your suggestion, and the reader is fine.

[reed1, 2016-09-13 23:36:37]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:36:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-09-14 00:09:43]

thanks, just what i was thinking.  lgtm

[reed1, 2016-09-14 00:10:31]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-09-14 00:10:40]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-09-14 00:10:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:25:22]

Description was changed from

==========
change write-image to use pipeverbs like everyone else, and add test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003
==========

to

==========
change write-image to use pipeverbs like everyone else, and add test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335973003

Committed:
https://skia.googlesource.com/skia/+/7e3ba9f88d64d901243799b61f497319e5970693
==========

[commit-bot: I haz the power, 2016-09-14 00:25:23]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7e3ba9f88d64d901243799b61f497319e5970693