Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2335963002: Refactor: remove SetDisplayWorkAreaInsets calls. (Closed)

Created:
4 years, 3 months ago by oshima
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Refactor: remove SetDisplayWorkAreaInsets calls. Use DisplayObserver's OnDisplayMetricsChanged instead when work area is changed. BUG=631557, 645210 Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212 Cr-Commit-Position: refs/heads/master@{#408507} Committed: https://chromium.googlesource.com/chromium/src/+/5da19c5e8c079e75e47550d04c8dd151219a4326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -41 lines) Patch
M ash/aura/wm_root_window_controller_aura.h View 3 chunks +9 lines, -2 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 4 chunks +19 lines, -5 lines 0 comments Download
M ash/common/shell_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/ash_popup_alignment_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/ash_popup_alignment_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wayland/server.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 3 months ago (2016-09-13 00:16:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5da19c5e8c079e75e47550d04c8dd151219a4326.

Powered by Google App Engine
This is Rietveld 408576698