Add WebrtcCaptureScheduler interface.

Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
Committed: https://crrev.com/0eaa5139dbab93ed41deefc56633d1ee19f0b832
Cr-Commit-Position: refs/heads/master@{#419632}

[Sergey Ulanov, 2016-09-12 23:08:44]

Description was changed from

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to capture video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.

BUG=645656
==========

to

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

BUG=645656
==========

[Sergey Ulanov, 2016-09-12 23:08:44]

sergeyu@chromium.org changed reviewers:
+ isheriff@chromium.org

[Sergey Ulanov, 2016-09-12 23:29:54]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2016-09-12 23:30:24]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-09-12 23:31:04]

Patchset #1 (id:40001) has been deleted

[Sergey Ulanov, 2016-09-12 23:36:06]

Description was changed from

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

BUG=645656
==========

to

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcCaptureSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed lower limit for FPS.

In the future WebrtcCaptureSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

[Sergey Ulanov, 2016-09-12 23:50:07]

Patchset #1 (id:60001) has been deleted

[Sergey Ulanov, 2016-09-12 23:50:36]

Description was changed from

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcCaptureSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed lower limit for FPS.

In the future WebrtcCaptureSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

to

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcCaptureSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcCaptureSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

[Irfan, 2016-09-14 20:01:30]

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
File remoting/codec/webrtc_video_encoder.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
remoting/codec/webrtc_video_encoder.h:28: bool clear_active_map = false;
would be good to document these

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
File remoting/codec/webrtc_video_encoder_vpx.cc (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
remoting/codec/webrtc_video_encoder_vpx.cc:553: // Clear active map first.
DCHECK(active_map_) ?

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
File remoting/protocol/webrtc_capture_scheduler.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:25: // Pauses the scheduler.
Pauses/Resumes ?

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:35: // frame. Returns false is the
frame should be dropped (e.g. when there are
Returns false if

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:37: virtual bool
GetEncoderFrameParams(
It is a bit strange to me that encoder params are being decided by the capture
scheduler.

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:42: virtual void OnFrameEncoded(
I may be imagining, but did you recently add ability to get a callback when a
frame is actually sent ?

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
File remoting/protocol/webrtc_capture_scheduler_simple.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler_simple.h:17: // It schedules each
frame after the previous one is expected to finish sending
s/finish sending the sender/finish sending/ ?

[Sergey Ulanov, 2016-09-16 00:02:48]

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
File remoting/codec/webrtc_video_encoder.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
remoting/codec/webrtc_video_encoder.h:28: bool clear_active_map = false;
On 2016/09/14 20:01:29, Irfan wrote:
> would be good to document these

Done.

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
File remoting/codec/webrtc_video_encoder_vpx.cc (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/codec/webrtc_v...
remoting/codec/webrtc_video_encoder_vpx.cc:553: // Clear active map first.
On 2016/09/14 20:01:29, Irfan wrote:
> DCHECK(active_map_) ?

Done.

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
File remoting/protocol/webrtc_capture_scheduler.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:25: // Pauses the scheduler.
On 2016/09/14 20:01:29, Irfan wrote:
> Pauses/Resumes ?

Done.

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:35: // frame. Returns false is the
frame should be dropped (e.g. when there are
On 2016/09/14 20:01:29, Irfan wrote:
> Returns false if 

Done.

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:37: virtual bool
GetEncoderFrameParams(
On 2016/09/14 20:01:29, Irfan wrote:
> It is a bit strange to me that encoder params are being decided by the capture
> scheduler.

The idea here is that frame scheduling logic shouldn't be separated from encoder
parameters, particularly for top-off. This also allows to pass frame duration
from the scheduler and the encoder doesn't have enough context to determine
duration.
Perhaps it should be called FrameScheduler, WDYT?

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:42: virtual void OnFrameEncoded(
On 2016/09/14 20:01:29, Irfan wrote:
> I may be imagining, but did you recently add ability to get a callback when a
> frame is actually sent ?

I was planning to do that, but haven't actually implemented it yet (it's not
straightforward to do it cleanly and safely as there are several layers between
the encoder and pacer).

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
File remoting/protocol/webrtc_capture_scheduler_simple.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler_simple.h:17: // It schedules each
frame after the previous one is expected to finish sending
On 2016/09/14 20:01:29, Irfan wrote:
> s/finish sending the sender/finish sending/ ?

Done.

[Irfan, 2016-09-16 17:21:19]

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
File remoting/protocol/webrtc_capture_scheduler.h (right):

https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
remoting/protocol/webrtc_capture_scheduler.h:37: virtual bool
GetEncoderFrameParams(
On 2016/09/16 00:02:47, Sergey Ulanov wrote:
> On 2016/09/14 20:01:29, Irfan wrote:
> > It is a bit strange to me that encoder params are being decided by the
capture
> > scheduler.
> 
> The idea here is that frame scheduling logic shouldn't be separated from
encoder
> parameters, particularly for top-off. This also allows to pass frame duration
> from the scheduler and the encoder doesn't have enough context to determine
> duration.
> Perhaps it should be called FrameScheduler, WDYT?

sgtm

[Sergey Ulanov, 2016-09-19 20:18:53]

On 2016/09/16 17:21:19, Irfan wrote:
>
https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
> File remoting/protocol/webrtc_capture_scheduler.h (right):
> 
>
https://codereview.chromium.org/2335923002/diff/80001/remoting/protocol/webrt...
> remoting/protocol/webrtc_capture_scheduler.h:37: virtual bool
> GetEncoderFrameParams(
> On 2016/09/16 00:02:47, Sergey Ulanov wrote:
> > On 2016/09/14 20:01:29, Irfan wrote:
> > > It is a bit strange to me that encoder params are being decided by the
> capture
> > > scheduler.
> > 
> > The idea here is that frame scheduling logic shouldn't be separated from
> encoder
> > parameters, particularly for top-off. This also allows to pass frame
duration
> > from the scheduler and the encoder doesn't have enough context to determine
> > duration.
> > Perhaps it should be called FrameScheduler, WDYT?
> 
> sgtm

Done. PTAL

[Sergey Ulanov, 2016-09-19 20:19:48]

Description was changed from

==========
Add WebrtcCaptureScheduler interface.

WebrtcCaptureScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcCaptureScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcCaptureSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcCaptureSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

to

==========
Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

[Irfan, 2016-09-19 20:22:20]

lgtm

codereview does not do a good job of telling me its just file rename

[Sergey Ulanov, 2016-09-19 21:04:54]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:06:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:46:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sergey Ulanov, 2016-09-19 22:24:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-19 22:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
isheriff@chromium.org
Link to the patchset: https://codereview.chromium.org/2335923002/#ps140001
(title: "include <algorithm>")

[commit-bot: I haz the power, 2016-09-19 22:25:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:40:29]

Description was changed from

==========
Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

to

==========
Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

[commit-bot: I haz the power, 2016-09-20 01:40:30]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-09-20 01:43:54]

Description was changed from

==========
Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656
==========

to

==========
Add WebrtcFrameScheduler interface.

WebrtcFrameScheduler is used by WebrtcVideoStream to schedule video
frames. WebrtcFrameScheduler implementations now are also responsible
for top-off logic that previously resided in WebrtcVideoCapturerVpx.
This will allow to switch between different frame scheduling strategies
in runtime.

WebrtcFrameSchedulerSimple implements the old scheduling logic with
the following two exceptions:
 - VPX active map is cleaned only after top-off is finished (top-off
   wasn't always working properly due to this issue).
 - Removed min limit for FPS.

In the future WebrtcFrameSchedulerSimple will need to be replaced
with a new scheduler that allows processing multiple frames in parallel.

BUG=645656

Committed: https://crrev.com/0eaa5139dbab93ed41deefc56633d1ee19f0b832
Cr-Commit-Position: refs/heads/master@{#419632}
==========

[commit-bot: I haz the power, 2016-09-20 01:43:55]

Patchset 4 (id:??) landed as
https://crrev.com/0eaa5139dbab93ed41deefc56633d1ee19f0b832
Cr-Commit-Position: refs/heads/master@{#419632}