Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2335903003: Revert of Disallow users modify canvas after it transfers control to offscreen (Closed)

Created:
4 years, 3 months ago by kjellander_chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, haraken, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow users modify canvas after it transfers control to offscreen (patchset #3 id:60001 of https://codereview.chromium.org/2323933004/ ) Reason for revert: Breaks webkit_tests consistently after submit: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22857 Original issue's description: > Disallow users modify canvas after it transfers control to offscreen > > After a canvas has transferred its control to Offscreen, we should not allow > users to perform resizing, toDataURL, toBlob and getContext. > > BUG=563852 > > Committed: https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed > Cr-Commit-Position: refs/heads/master@{#418114} TBR=junov@chromium.org,xlai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563852 Committed: https://crrev.com/2d2c91639476064fd5e5d4b08cae3fd65ca5b8da Cr-Commit-Position: refs/heads/master@{#418188}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
kjellander_chromium
Created Revert of Disallow users modify canvas after it transfers control to offscreen
4 years, 3 months ago (2016-09-13 07:42:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335903003/1
4 years, 3 months ago (2016-09-13 07:42:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 07:43:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 07:45:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d2c91639476064fd5e5d4b08cae3fd65ca5b8da
Cr-Commit-Position: refs/heads/master@{#418188}

Powered by Google App Engine
This is Rietveld 408576698