Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 23359003: Eliminate unused PYAUTO tests and TestingAutomationProvider methods (Closed)

Created:
7 years, 4 months ago by stevenjb
Modified:
7 years, 3 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, robertshield, dyu1
Visibility:
Public.

Description

Eliminate unused PYAUTO tests and TestingAutomationProvider methods My understanding is that none of these tests are currently being run, so we should eliminate them so that we can remove the supporting code. BUG=259896 R=dennisjeffrey@chromium.org, phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219570

Patch Set 1 #

Total comments: 1

Patch Set 2 : Restore ConnectToHiddenWifiNetwork #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase + restore ConnectToHiddenWifiNetwork (complete) #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2937 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 3 2 chunks +0 lines, -284 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 2 4 chunks +0 lines, -34 lines 0 comments Download
D chrome/test/functional/chromeos_cellular_sanity.py View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/functional/chromeos_device_policy.py View 1 chunk +0 lines, -216 lines 0 comments Download
D chrome/test/functional/chromeos_ephemeral.py View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/test/functional/chromeos_gsm_compliance.py View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/test/functional/chromeos_login.py View 1 chunk +0 lines, -371 lines 0 comments Download
D chrome/test/functional/chromeos_offline.py View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/functional/chromeos_onc.py View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/test/functional/chromeos_oobe.py View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/test/functional/chromeos_retail_mode.py View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/test/functional/chromeos_txt_msg_functional.py View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/test/functional/chromeos_vpn.py View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/test/functional/chromeos_wifi_compliance.py View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/test/functional/chromeos_wifi_functional.py View 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/test/functional/wifi_downloads.py View 1 chunk +0 lines, -201 lines 0 comments Download
D chrome/test/functional/wifi_notification.py View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/test/pyautolib/chromeos_network.py View 3 chunks +0 lines, -180 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 5 chunks +0 lines, -360 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
stevenjb
Speak now...
7 years, 4 months ago (2013-08-20 22:44:15 UTC) #1
krisr
On 2013/08/20 22:44:15, stevenjb (chromium) wrote: > Speak now... You can probably remove the stuff ...
7 years, 4 months ago (2013-08-20 22:50:11 UTC) #2
armansito
On 2013/08/20 22:50:11, krisr wrote: > On 2013/08/20 22:44:15, stevenjb (chromium) wrote: > > Speak ...
7 years, 4 months ago (2013-08-20 23:01:59 UTC) #3
gauravsh
On 2013/08/20 23:01:59, armansito wrote: > On 2013/08/20 22:50:11, krisr wrote: > > On 2013/08/20 ...
7 years, 4 months ago (2013-08-20 23:29:39 UTC) #4
gauravsh
How are you determining which methods are unused? I was working on a CL that ...
7 years, 4 months ago (2013-08-20 23:49:21 UTC) #5
armansito
On 2013/08/20 23:49:21, gauravsh wrote: > How are you determining which methods are unused? I ...
7 years, 4 months ago (2013-08-20 23:55:36 UTC) #6
stevenjb
On 2013/08/20 23:49:21, gauravsh wrote: > How are you determining which methods are unused? I ...
7 years, 4 months ago (2013-08-21 00:23:08 UTC) #7
stevenjb
+nkostylev to ensure we aren't actually using chromeos_login.py or any of the other tests listed.
7 years, 4 months ago (2013-08-21 17:57:17 UTC) #8
Nikita (slow)
I don't think that these tests are used. Achuith?
7 years, 4 months ago (2013-08-21 18:06:35 UTC) #9
wiley1
Sorry, I was OOO. We certainly don't monitor these tests or run them by hand, ...
7 years, 4 months ago (2013-08-22 18:07:57 UTC) #10
stevenjb
+dennisjeffrey@ for OWNER I managed to run chromeos_wifi_sanity and discovered that, at least on link, ...
7 years, 4 months ago (2013-08-22 20:30:25 UTC) #11
gauravsh
On 2013/08/22 20:30:25, stevenjb (chromium) wrote: > +dennisjeffrey@ for OWNER > > I managed to ...
7 years, 4 months ago (2013-08-22 20:49:59 UTC) #12
gauravsh
+pstew just in case he has any memory of these tests actually ever being run
7 years, 4 months ago (2013-08-22 20:51:41 UTC) #13
dennis_jeffrey
To my knowledge, none of the PyAuto tests in this CL are being used. However, ...
7 years, 4 months ago (2013-08-22 20:53:57 UTC) #14
stevenjb
On 2013/08/22 20:53:57, dennis_jeffrey wrote: > To my knowledge, none of the PyAuto tests in ...
7 years, 4 months ago (2013-08-22 22:29:22 UTC) #15
Paul Stewart
I have a very specific memory of never using or looking at these tests before. ...
7 years, 4 months ago (2013-08-22 22:32:30 UTC) #16
krisr
On 2013/08/22 22:29:22, stevenjb (chromium) wrote: > On 2013/08/22 20:53:57, dennis_jeffrey wrote: > > To ...
7 years, 4 months ago (2013-08-22 22:33:10 UTC) #17
stevenjb
Gerrit CL: https://gerrit.chromium.org/gerrit/#/c/66721/ Assuming that lands without breaking anything, if someone is brave enough to ...
7 years, 4 months ago (2013-08-23 01:35:48 UTC) #18
dennis_jeffrey
LGTM
7 years, 4 months ago (2013-08-23 01:38:40 UTC) #19
stevenjb
+phajdan.jr@ for c/b/automation OWNER
7 years, 4 months ago (2013-08-23 21:26:01 UTC) #20
Paweł Hajdan Jr.
automation LGTM I hope we can delete all of it soon.
7 years, 4 months ago (2013-08-23 23:55:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/23359003/20001
7 years, 3 months ago (2013-08-26 18:17:03 UTC) #22
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-08-26 18:26:47 UTC) #23
stevenjb
7 years, 3 months ago (2013-08-26 18:38:27 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 manually as r219570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698