Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2335863002: [blimp] Fix theme color in tab switcher (Closed)

Created:
4 years, 3 months ago by nyquist
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[blimp] Fix theme color in tab switcher Before the CL https://codereview.chromium.org/2325763003/ landed, it was possible to use a theme color without alpha for the tab switcher toolbar, because the code was using the alpha from the underlying resource instead. However after that CL this was no longer possible and a correct theme color is required. The CL that added theme colors to the tab switcher for the new tab page for blimp tabs ( https://codereview.chromium.org/2325893002/ ) landed around the same time, and there was no test, so this was not caught in that CL, and it continued to use a theme color without alpha. This CL just adds the alpha channel to the theme color from Blimp, which means that it now propagates correctly throughout the codebase. BUG=644467, 644774 Committed: https://crrev.com/5f96e9a9fd95d7a9928de17effb1788de5f66691 Cr-Commit-Position: refs/heads/master@{#418078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nyquist
dtrainor: PTAL
4 years, 3 months ago (2016-09-12 21:37:43 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 3 months ago (2016-09-12 21:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335863002/1
4 years, 3 months ago (2016-09-12 21:39:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 22:26:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:28:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f96e9a9fd95d7a9928de17effb1788de5f66691
Cr-Commit-Position: refs/heads/master@{#418078}

Powered by Google App Engine
This is Rietveld 408576698