Issue 233583002: Fix crash in skia graphics context teardown after gpu context loss

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233583002: Fix crash in skia graphics context teardown after gpu context loss (Closed)

Created:
6 years, 8 months ago by Justin Novosad

Modified:
6 years, 8 months ago

Reviewers:
dshwang, piman

CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in skia graphics context teardown after gpu context loss GrContextForWebGraphicsContext3D::OnLostContext() was calling GrContext::contextLost() which has the wrong behavior: it assumes that the gpu context is still valid but that all of its resources have been lost, so it attempts to reinitialize resources that are used internally by skia. The correct action is to call GrContext::contextDestroyed(), which signals that the gpu context is no longer usable. BUG=361555 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263056

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/233583002/1

6 years, 8 months ago (2014-04-10 18:20:12 UTC) #5

Message was sent while issue was closed.

Change committed as 263056

Expand Messages | Collapse Messages