Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2335783003: Fixup SkRRectsGaussianEdgeShader's shaders (Closed)

Created:
4 years, 3 months ago by robertphillips
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixup SkRRectsGaussianEdgeShader's shaders This fixes some visual artifacts in the original CL. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335783003 Committed: https://skia.googlesource.com/skia/+/f619a7af55d4f54101b8068eeb20569be868a6da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -62 lines) Patch
M gm/reveal.cpp View 12 chunks +39 lines, -20 lines 0 comments Download
M src/effects/SkRRectsGaussianEdgeShader.cpp View 5 chunks +47 lines, -42 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 3 months ago (2016-09-12 19:39:20 UTC) #4
bsalomon
lgtm
4 years, 3 months ago (2016-09-12 19:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335783003/1
4 years, 3 months ago (2016-09-13 00:25:00 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 00:25:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f619a7af55d4f54101b8068eeb20569be868a6da

Powered by Google App Engine
This is Rietveld 408576698