Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2335663002: Reland of Make secondary abi work for component build (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Make secondary abi work for component build Previously reverted in: https://codereview.chromium.org/2333593002/ Reason for reland: Removed offending import for real this time. BUG=622855 Committed: https://crrev.com/06d80348f0e49fe7558ee8b3adad6f56078b5842 Cr-Commit-Position: refs/heads/master@{#417942}

Patch Set 1 #

Patch Set 2 : Delete rogue import and add comment to guard future additions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -43 lines) Patch
M build/android/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/write_build_config.py View 1 3 chunks +21 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 6 chunks +61 lines, -2 lines 0 comments Download
M build/config/android/rules.gni View 1 9 chunks +86 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
agrieve
Created Reland of Make secondary abi work for component build
4 years, 3 months ago (2016-09-12 14:02:25 UTC) #1
agrieve
On 2016/09/12 14:02:25, agrieve wrote: > Created Reland of Make secondary abi work for component ...
4 years, 3 months ago (2016-09-12 14:18:23 UTC) #5
Michael Achenbach
lgtm on the import-fix! thanks!
4 years, 3 months ago (2016-09-12 14:29:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335663002/110001
4 years, 3 months ago (2016-09-12 15:22:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:110001)
4 years, 3 months ago (2016-09-12 15:26:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 15:28:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06d80348f0e49fe7558ee8b3adad6f56078b5842
Cr-Commit-Position: refs/heads/master@{#417942}

Powered by Google App Engine
This is Rietveld 408576698