Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8529)

Unified Diff: chrome/browser/ui/website_settings/permission_prompt.h

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)
Patch Set: address review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/permission_prompt.h
diff --git a/chrome/browser/ui/website_settings/permission_prompt.h b/chrome/browser/ui/website_settings/permission_prompt.h
index 7e23677186c5172f1fd1ccefbbe3e7af8f0908ce..ff2bef758e64991d236816d7c1606b43ce1feaf1 100644
--- a/chrome/browser/ui/website_settings/permission_prompt.h
+++ b/chrome/browser/ui/website_settings/permission_prompt.h
@@ -11,10 +11,13 @@
#include "base/callback.h"
#include "ui/gfx/native_widget_types.h"
-class Browser;
class PermissionRequestManager;
class PermissionRequest;
+namespace content {
+class WebContents;
+}
+
// This class is the platform-independent interface through which the permission
// request managers (which are one per tab) communicate to the UI surface.
// When the visible tab changes, the UI code must provide an object of this type
@@ -33,10 +36,13 @@ class PermissionPrompt {
virtual void Closing() = 0;
};
- typedef base::Callback<std::unique_ptr<PermissionPrompt>(Browser*)> Factory;
+ typedef base::Callback<std::unique_ptr<PermissionPrompt>(
+ content::WebContents*)>
+ Factory;
// Create a platform specific instance.
- static std::unique_ptr<PermissionPrompt> Create(Browser* browser);
+ static std::unique_ptr<PermissionPrompt> Create(
+ content::WebContents* web_contents);
virtual ~PermissionPrompt() {}
// Sets the delegate which will receive UI events forwarded from the prompt.
« no previous file with comments | « chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698