Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8166)

Unified Diff: chrome/browser/ui/website_settings/mock_permission_prompt_factory.h

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)
Patch Set: address review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
diff --git a/chrome/browser/ui/website_settings/mock_permission_prompt_factory.h b/chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
index 7259affd45493833fa4ef0c946178402a7912ece..e09ee62591fecc5567d629dde58cc1b12ab7f3ca 100644
--- a/chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
+++ b/chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
@@ -14,6 +14,10 @@ class Browser;
class MockPermissionPrompt;
class PermissionPrompt;
+namespace content {
+class WebContents;
+}
+
// Provides a skeleton class for both unit and browser testing when trying to
// test the bubble manager logic. Should not be used for anything that requires
// actual UI.
@@ -25,7 +29,7 @@ class MockPermissionPromptFactory {
~MockPermissionPromptFactory();
// Create method called by the PBM to show a bubble.
- std::unique_ptr<PermissionPrompt> Create(Browser* browser);
+ std::unique_ptr<PermissionPrompt> Create(content::WebContents* web_contents);
void SetCanUpdateUi(bool can_update_ui);
@@ -53,7 +57,8 @@ class MockPermissionPromptFactory {
// This shouldn't be called. Is here to fail tests that try to create a bubble
// after the factory has been destroyed.
- static std::unique_ptr<PermissionPrompt> DoNotCreate(Browser* browser);
+ static std::unique_ptr<PermissionPrompt> DoNotCreate(
+ content::WebContents* web_contents);
void UpdateResponseType();
void ShowView(MockPermissionPrompt* view);

Powered by Google App Engine
This is Rietveld 408576698