Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2335603002: [turbofan] Properly emit vsqrtsd if AVX is enabled. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly emit vsqrtsd if AVX is enabled. We shall not mix AVX and SSE instructions as that can cause performance regressions in some areas, so make sure to emit vsqrtsd instead of sqrtsd when AVX is enabled. R=ahaas@chromium.org Committed: https://crrev.com/4cf5ee6b38fb5de4085796a5d6c1b181722f8bce Cr-Commit-Position: refs/heads/master@{#39349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-12 11:20:07 UTC) #1
ahaas
lgtm
4 years, 3 months ago (2016-09-12 11:22:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335603002/1
4 years, 3 months ago (2016-09-12 11:23:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 11:50:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:51:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cf5ee6b38fb5de4085796a5d6c1b181722f8bce
Cr-Commit-Position: refs/heads/master@{#39349}

Powered by Google App Engine
This is Rietveld 408576698