Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2335573003: Move String::isSafeToSendToAnotherThread to StringImpl. (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move String::isSafeToSendToAnotherThread to StringImpl. String should be a thin wrapper over StringImpl and other functions. I also added isSafeToSendToAnotherThread() to AtomicString since this method is useful there too. Committed: https://crrev.com/63560883cbe650844ed93b727825020b49c6a3f9 Cr-Commit-Position: refs/heads/master@{#418115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
esprehn
4 years, 3 months ago (2016-09-12 21:55:39 UTC) #6
haraken
LGTM
4 years, 3 months ago (2016-09-12 23:39:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335573003/1
4 years, 3 months ago (2016-09-13 00:12:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 00:16:10 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 00:20:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63560883cbe650844ed93b727825020b49c6a3f9
Cr-Commit-Position: refs/heads/master@{#418115}

Powered by Google App Engine
This is Rietveld 408576698