Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2335553002: Revert of [builtins] Move StringNormalize to a cpp builtin. (Closed)

Created:
4 years, 3 months ago by petermarshall
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Move StringNormalize to a cpp builtin. (patchset #10 id:180001 of https://codereview.chromium.org/2315343002/ ) Reason for revert: Tests fail when i18n is switched off, trybots do not run this configuration Original issue's description: > [builtins] Move StringNormalize to a cpp builtin. > > BUG=v8:5364 > > Committed: https://crrev.com/7f84a6a2e7000bebba49354b4648346ff606ca34 > Cr-Commit-Position: refs/heads/master@{#39331} TBR=bmeurer@chromium.org,franzih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5364 Committed: https://crrev.com/ae71fbc31f18360dde466006bc12756df5ed4cbc Cr-Commit-Position: refs/heads/master@{#39332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -38 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/js/string.js View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
petermarshall
Created Revert of [builtins] Move StringNormalize to a cpp builtin.
4 years, 3 months ago (2016-09-12 08:33:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335553002/1
4 years, 3 months ago (2016-09-12 08:33:13 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-12 08:33:18 UTC) #5
Franzi
lgtm
4 years, 3 months ago (2016-09-12 08:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335553002/1
4 years, 3 months ago (2016-09-12 08:46:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 08:47:03 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 08:47:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae71fbc31f18360dde466006bc12756df5ed4cbc
Cr-Commit-Position: refs/heads/master@{#39332}

Powered by Google App Engine
This is Rietveld 408576698