[Interpreter] Adds stackcheck in InterpreterPushArgsAndCall/Construct builtins.

test/mjsunit/stack-traces-overflow.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 22 matching lines @@
 }
 function rec1(a) { rec1(a+1); }
 function rec2(a) { rec3(a+1); }
 function rec3(a) { rec2(a+1); }
 
 // Test stack trace has correct function location at top of the stack.
 try {
   overflow();
 } catch (e) {
   var first_frame = e.stack.split("\n")[1]
-  assertTrue(first_frame.indexOf("stack-traces-overflow.js:30:18") > 0);
+  // The overflow can happen when pushing the arguments (in interpreter) or when
+  // the new function execution is starting. So the stack trace could either
+  // point to start of the function (stack-traces-overflow.js30:18) or to the
+  // location of call (stack-traces-overflow.js32:3).
+  assertTrue((first_frame.indexOf("stack-traces-overflow.js:30:18") > 0) ||
+             (first_frame.indexOf("stack-traces-overflow.js:32:3") > 0) );

[mythria, 2016/09/12 13:55:34]

Michi, Does full-codegen only check for a stack overflow at the start of
function? I tried looking at full-codegen, if I understand correctly it only
checks if the number of locals make the stack overflow. Doesn't it also check
that temporary values it pushes while evaluating the function does not overflow
the stack? I just wanted to be sure, this check is correct.

 }
 
 // Test stack trace getter and setter.
 try {
   rec1(0);
 } catch (e) {
   assertTrue(e.stack.indexOf("rec1") > 0);
   e.stack = "123";
   assertEquals("123", e.stack);
 }
@@ skipping 90 matching lines @@
   assertEquals("abc", e.stack);
 }
 
 Error.stackTraceLimit = 3;
 Error = "";  // Overwrite Error in the global object.
 try {
   rec1(0);
 } catch (e) {
   assertEquals(4, e.stack.split('\n').length);
 }