Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: ui/views/controls/md_slider.h

Issue 2335513002: Adding ripple effect for clicks on MD slider (Closed)
Patch Set: adding animation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/md_slider.cc » ('j') | ui/views/controls/md_slider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/md_slider.h
diff --git a/ui/views/controls/md_slider.h b/ui/views/controls/md_slider.h
index d9ceeecf0ca3785f5792e88e933e70acd777d052..28d016ebe5ae13aa22e09b5c5543e461c267bd3b 100644
--- a/ui/views/controls/md_slider.h
+++ b/ui/views/controls/md_slider.h
@@ -6,6 +6,7 @@
#define UI_VIEWS_CONTROLS_MD_SLIDER_H_
#include "base/macros.h"
+#include "ui/gfx/animation/animation_delegate.h"
bruthig 2016/09/21 00:27:46 nit: You shouldn't need to include this since slid
yiyix 2016/09/21 15:20:52 Done.
#include "ui/views/controls/slider.h"
#include "ui/views/view.h"
#include "ui/views/views_export.h"
@@ -29,10 +30,22 @@ class VIEWS_EXPORT MdSlider : public Slider {
protected:
// ui::Slider:
int GetThumbWidth() override;
+ void SetFocus(bool focus) override;
private:
+ // gfx::AnimationDelegate:
+ void AnimationProgressed(const gfx::Animation* animation) override;
+
// Record whether the slider is in the active state or the disabled state.
bool is_active_;
+
+ // Animating value of the current stroke size of the thumb's highlight.
+ float animating_thumb_value_;
+
+ // The desired value of stroke of the thumb's highlight.
+ float value_;
bruthig 2016/09/21 00:27:46 The variable name |highlight_radius_| would be mor
yiyix 2016/09/21 15:20:52 Done.
+
+ std::unique_ptr<gfx::SlideAnimation> highlight_animation_;
bruthig 2016/09/21 00:27:46 nit: You should forward declare SlideAnimation.
yiyix 2016/09/21 15:20:52 Done.
};
} // namespace views
« no previous file with comments | « no previous file | ui/views/controls/md_slider.cc » ('j') | ui/views/controls/md_slider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698