Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: ui/views/controls/md_slider.h

Issue 2335513002: Adding ripple effect for clicks on MD slider (Closed)
Patch Set: imporve animation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/md_slider.cc » ('j') | ui/views/controls/md_slider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/md_slider.h
diff --git a/ui/views/controls/md_slider.h b/ui/views/controls/md_slider.h
index d9ceeecf0ca3785f5792e88e933e70acd777d052..b88012e29e1d2d26f017708d2689507d1af557c0 100644
--- a/ui/views/controls/md_slider.h
+++ b/ui/views/controls/md_slider.h
@@ -29,10 +29,19 @@ class VIEWS_EXPORT MdSlider : public Slider {
protected:
// ui::Slider:
int GetThumbWidth() override;
+ void SetHighlighted(bool focus) override;
private:
+ // gfx::AnimationDelegate:
+ void AnimationProgressed(const gfx::Animation* animation) override;
+
// Record whether the slider is in the active state or the disabled state.
bool is_active_;
+
+ // Animating value of the current stroke size of the thumb's highlight.
+ float animating_thumb_value_;
bruthig 2016/09/22 21:05:24 Can you use a more descriptive name than |animatin
yiyix 2016/09/23 20:35:37 sure, i also noticed that i forget to change the d
+
+ std::unique_ptr<gfx::SlideAnimation> highlight_animation_;
};
} // namespace views
« no previous file with comments | « no previous file | ui/views/controls/md_slider.cc » ('j') | ui/views/controls/md_slider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698