Adding ripple effect for clicks on MD slider

ui/views/controls/slider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_SLIDER_H_
 #define UI_VIEWS_CONTROLS_SLIDER_H_
 
 #include "base/macros.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/views/view.h"
@@ skipping 54 matching lines @@
   void set_enable_accessibility_events(bool enabled) {
     accessibility_events_enabled_ = enabled;
   }
 
   void set_focus_border_color(SkColor color) { focus_border_color_ = color; }
 
   // Update UI based on control on/off state.
   virtual void UpdateState(bool control_on) = 0;
 
  protected:
+  virtual void SetFocus(bool focus){};

[bruthig, 2016/09/21 00:27:46]

The 'focus' concept is already defined on View and this 'focus'  means something
a little different.  Instead of overloading the term might I suggest renaming
SetFocus() to SetHighlighted().

[bruthig, 2016/09/21 00:27:46]

Move definition to .cc file.

[yiyix, 2016/09/21 15:20:52]

Done.

+  bool OnMousePressed(const ui::MouseEvent& event) override;
+  void OnMouseReleased(const ui::MouseEvent& event) override;

[bruthig, 2016/09/21 00:27:46]

OnMousePressed() and OnMouseReleased() should be grouped with the other similar
overrides on line 91.

[yiyix, 2016/09/21 15:20:52]

Done.

+
+ protected:

[bruthig, 2016/09/21 00:27:46]

nit: Remove, protected is already declared on line 74.

[yiyix, 2016/09/21 15:20:52]

Sorry again, It is not a fully finish version when i sent it out...  I was
asking for a first look to look at the idea of the animation implementation.

   explicit Slider(SliderListener* listener);

[bruthig, 2016/09/21 00:27:46]

Style guide specifies constructors should be declared before functions.

[yiyix, 2016/09/21 15:20:53]

Done.

 
   // Returns the current position of the thumb on the slider.
   float GetAnimatingValue() const;
 
   virtual int GetThumbWidth() = 0;
 
+  // gfx::AnimationDelegate:
+  void AnimationProgressed(const gfx::Animation* animation) override;
+
   // views::View:
   void OnPaint(gfx::Canvas* canvas) override;
 
  private:
   friend class test::SliderTestApi;
 
   void SetValueInternal(float value, SliderChangeReason reason);
 
   // Should be called on the Mouse Down event. Used to calculate relative
   // position of the mouse cursor (or the touch point) on the button to
   // accurately move the button using the MoveButtonTo() method.
   void PrepareForMove(const int new_x);
 
   // Moves the button to the specified point and updates the value accordingly.
   void MoveButtonTo(const gfx::Point& point);
 
   void OnPaintFocus(gfx::Canvas* canvas);
 
   // Notify the listener_, if not NULL, that dragging started.
   void OnSliderDragStarted();
 
   // Notify the listener_, if not NULL, that dragging ended.
   void OnSliderDragEnded();
 
   // views::View:
   const char* GetClassName() const override;
   gfx::Size GetPreferredSize() const override;
-  bool OnMousePressed(const ui::MouseEvent& event) override;
   bool OnMouseDragged(const ui::MouseEvent& event) override;
-  void OnMouseReleased(const ui::MouseEvent& event) override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;
   void GetAccessibleState(ui::AXViewState* state) override;
   void OnFocus() override;
   void OnBlur() override;
 
   // ui::EventHandler:
   void OnGestureEvent(ui::GestureEvent* event) override;
 
-  // gfx::AnimationDelegate:
-  void AnimationProgressed(const gfx::Animation* animation) override;
-
   void set_listener(SliderListener* listener) {
     listener_ = listener;
   }
 
   SliderListener* listener_;
 
   std::unique_ptr<gfx::SlideAnimation> move_animation_;
 
   float value_;
   float keyboard_increment_;
   float animating_value_;
   bool value_is_valid_;
   base::string16 accessible_name_;
   bool accessibility_events_enabled_;
   SkColor focus_border_color_;
 
   // Relative position of the mouse cursor (or the touch point) on the slider's
   // button.
   int initial_button_offset_;
 
   DISALLOW_COPY_AND_ASSIGN(Slider);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_SLIDER_H_