Adding ripple effect for clicks on MD slider

ui/views/controls/md_slider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MD_SLIDER_H_
 #define UI_VIEWS_CONTROLS_MD_SLIDER_H_
 
 #include "base/macros.h"
+#include "ui/gfx/animation/animation_delegate.h"

[bruthig, 2016/09/21 00:27:46]

nit: You shouldn't need to include this since slider.h already does.

[yiyix, 2016/09/21 15:20:52]

Done.

 #include "ui/views/controls/slider.h"
 #include "ui/views/view.h"
 #include "ui/views/views_export.h"
 
 namespace views {
 
 // TODO(yiyix): When material design is enabled by default, use
 // MaterialDesignSlider as the default slider implementation. (crbug.com/614453)
 class VIEWS_EXPORT MdSlider : public Slider {
  public:
   explicit MdSlider(SliderListener* listener);
   ~MdSlider() override;
 
   // ui::Slider:
   void UpdateState(bool control_on) override;
 
   // views::View:
   void OnPaint(gfx::Canvas* canvas) override;
   const char* GetClassName() const override;
 
  protected:
   // ui::Slider:
   int GetThumbWidth() override;
+  void SetFocus(bool focus) override;
 
  private:
+  // gfx::AnimationDelegate:
+  void AnimationProgressed(const gfx::Animation* animation) override;
+
   // Record whether the slider is in the active state or the disabled state.
   bool is_active_;
+
+  // Animating value of the current stroke size of the thumb's highlight.
+  float animating_thumb_value_;
+
+  // The desired value of stroke of the thumb's highlight.
+  float value_;

[bruthig, 2016/09/21 00:27:46]

The variable name |highlight_radius_| would be more appropriate/descriptive than
the generic |value_|.

[yiyix, 2016/09/21 15:20:52]

Done.

+
+  std::unique_ptr<gfx::SlideAnimation> highlight_animation_;

[bruthig, 2016/09/21 00:27:46]

nit: You should forward declare SlideAnimation.

[yiyix, 2016/09/21 15:20:52]

Done.

 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MD_SLIDER_H_