Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2335503002: Finds the nearest display to show the follow-cursor IME window, instead of using the primary one. (Closed)

Created:
4 years, 3 months ago by Shu Chen
Modified:
4 years, 3 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finds the nearest display to show the follow-cursor IME window, instead of using the primary one. BUG=645842 Committed: https://crrev.com/e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62 Cr-Commit-Position: refs/heads/master@{#417912}

Patch Set 1 #

Patch Set 2 : Finds the nearest display to show the follow-cursor IME window, instead of using the primary one. #

Patch Set 3 : . #

Patch Set 4 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/ime/ime_window.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335503002/60001
4 years, 3 months ago (2016-09-12 09:21:47 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-12 09:21:49 UTC) #4
Shu Chen
4 years, 3 months ago (2016-09-12 09:46:49 UTC) #6
Azure Wei
lgtm
4 years, 3 months ago (2016-09-12 09:47:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335503002/60001
4 years, 3 months ago (2016-09-12 09:47:49 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-12 10:34:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 10:37:19 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e5f54fe9dfb5a8743b16eba7e85ace45e3d7ef62
Cr-Commit-Position: refs/heads/master@{#417912}

Powered by Google App Engine
This is Rietveld 408576698