Extend message for sync presubmit

Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo: notification type "WIFI_CREDENTIALIEA" does not match proto message name defined in sync.proto: "wifi_credentials"'

BUG=

Committed: https://crrev.com/343264820eb254bdab3dbeef0082e8e1bb307532
Cr-Commit-Position: refs/heads/master@{#419263}

[skau, 2016-09-13 22:37:11]

Description was changed from

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind comitters to refer to
the definition of the struct for more information.

BUG=
==========

to

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo:
notification type "WIFI_CREDENTIALIEA" does not match proto message name defined
in sync.proto: "wifi_credentials"'

BUG=
==========

[skau, 2016-09-13 22:37:11]

skau@chromium.org changed reviewers:
+ pavely@chromium.org, zea@chromium.org

[skau, 2016-09-13 22:38:19]

The sync presubmit message confused me so I added more information.  Let me know
if you think it's an improvement.

[pavely, 2016-09-13 23:19:16]

lgtm

[skau, 2016-09-16 19:25:54]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:26:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:04:30]

Description was changed from

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo:
notification type "WIFI_CREDENTIALIEA" does not match proto message name defined
in sync.proto: "wifi_credentials"'

BUG=
==========

to

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo:
notification type "WIFI_CREDENTIALIEA" does not match proto message name defined
in sync.proto: "wifi_credentials"'

BUG=
==========

[commit-bot: I haz the power, 2016-09-16 20:04:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 20:06:02]

Description was changed from

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo:
notification type "WIFI_CREDENTIALIEA" does not match proto message name defined
in sync.proto: "wifi_credentials"'

BUG=
==========

to

==========
Extend message for sync presubmit

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo:
notification type "WIFI_CREDENTIALIEA" does not match proto message name defined
in sync.proto: "wifi_credentials"'

BUG=

Committed: https://crrev.com/343264820eb254bdab3dbeef0082e8e1bb307532
Cr-Commit-Position: refs/heads/master@{#419263}
==========

[commit-bot: I haz the power, 2016-09-16 20:06:03]

Patchset 3 (id:??) landed as
https://crrev.com/343264820eb254bdab3dbeef0082e8e1bb307532
Cr-Commit-Position: refs/heads/master@{#419263}